Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-text/nfoview-1.27 version bump #13038

Closed
wants to merge 2 commits into from
Closed

app-text/nfoview-1.27 version bump #13038

wants to merge 2 commits into from

Conversation

tillschaefer
Copy link
Contributor

  • migrate to EAPI 7
  • add gettext dependency
  • remove versions not tested against python 3.7

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @tillschaefer
Areas affected: ebuilds
Packages affected: app-text/nfoview

app-text/nfoview: @tillschaefer, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Sep 25, 2019
juippis
juippis reviewed Sep 26, 2019
View reviewed changes
app-text/nfoview/nfoview-1.27.ebuild Outdated

PYTHON_COMPAT=( python3_{5,6,7} )

inherit distutils-r1 gnome2-utils xdg-utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnome2-utils isnt' needed here anymore, and using it for icon_cache_update on an EAPI-7 ebuild shouldnt even work. Use xdg_icon_cache_update instead. R

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good to know. Is changed now.

app-text/nfoview/nfoview-1.27.ebuild Outdated
SLOT="0"
IUSE=""

BDEPEND="${PYTHON_DEP}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here, but you are right in putting it into BDEPEND.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tillschaefer
app-text/nfoview: bump to version 1.27
1b7bd3e 
migrate to EAPI 7
add gettext dependency

Package-Manager: Portage-2.3.69, Repoman-2.3.16
Signed-off-by: Till Schäfer <till2.schaefer@uni-dortmund.de>
@tillschaefer
app-text/nfoview: remove pythom compat < 3.7
337cc1f 
Package-Manager: Portage-2.3.69, Repoman-2.3.16
Signed-off-by: Till Schäfer <till2.schaefer@uni-dortmund.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-09-26 18:37 UTC
Newest commit scanned: 337cc1f
Status: ✅ good

No issues found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@tillschaefer @gentoo-bot @gentoo-repo-qa-bot @juippis