l10n.eclass: update l10n_find_plocales_changes() #1308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsieurp
added
bugfix
assigned
| einfo "Looking in '${dir}' for new locales ..." | ||
| pushd "${dir}" >/dev/null || die "Cannot access ${dir}" | ||
| local current= | ||
| for l in ${pre}*${post} ; do |
There was a problem hiding this comment.
Thank you very much @jlec , didn't know bash doesn't limit scope of loop vars.
This update does - allow to span PLOCALES over multiple lines - make code more readable Gentoo-Bug: 513242
|
What's holding this back? |
|
@rindeal: Hi. Eclass changes must be discussed on the gentoo-dev mailing first. Not all Gentoo devs use and/or like Github. Thank you. |
|
I announced it there on the same day as here, but no one responded and apparently no one read it.
|
|
I guess this can be closed now. For anyone interested, I've completely reworked the eclass and added many cool features, while keeping full backwards compatibility. It can be seen in action in my overlay - https://github.com/rindeal/gentoo-overlay/blob/master/eclass/l10n.eclass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update does
Gentoo-Bug: 513242
@yngwin @jlec