Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pgadmin4-4.13 #13112

Closed
wants to merge 1 commit into from
Closed

Added pgadmin4-4.13 #13112

wants to merge 1 commit into from

Conversation

rain0r
Copy link
Contributor

@rain0r rain0r commented Sep 30, 2019

Signed-off-by: Rainer Hihn hihn.rainer@gmail.com

No bug ticket for this one.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @rain0r
Areas affected: ebuilds
Packages affected: dev-db/pgadmin4

dev-db/pgadmin4: @gentoo/postgresql

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Sep 30, 2019
Bug: https://bugs.gentoo.org/695970

Signed-off-by: Rainer Hihn <hihn.rainer@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-10-01 10:38 UTC
Newest commit scanned: f28631e
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/cfde3e8/output.html#dev-db/pgadmin4

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/cfde3e8/output.html#games-action/crimsonland
https://qa-reports.gentoo.org/output/gentoo-ci/cfde3e8/output.html#games-roguelike/neon-chrome

@rain0r
Copy link
Contributor Author

rain0r commented Oct 5, 2019

Anything more I could do to get this into portage?

@titanofold
Copy link
Member

I'm sorry for the delay in responding here.

Unfortunately, we won't be able to accept this PR because there's a bit more work that needed to be done. I've already done this in my local overlay, otherwise I would have helped you (and I didn't realize this PR was here before I started working on it).

The Python module dependencies have been shortened and updated. You can find these in the requirements.txt file. Four Python modules needed to be updated in Portage in order to satisfy the new requirements:

  • dev-python/flask-migrate to 2.5.2
  • dev-python/flask-htmlmin to 1.5.0
  • dev-python/flask-sqlalchemy to 2.4.1
  • dev-python/python-dateutil to 2.8.0

We should also try to improve the ebuilds rather than just focusing on bumping. There were a couple bugs that needed a minor tweak in the ebuild to resolve. (https://bugs.gentoo.org/689678 and https://bugs.gentoo.org/689708)

I do appreciate the work you've done, and encourage you to keep at it. You can always email me directly if you have any questions.

Further, as I'm in school full time and work full time, I'm not terribly concerned about which packages I maintain get touched except for dev-db/postgresql. So, any Gentoo dev can help you.

@titanofold titanofold closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants