Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-admin/gam-server: Support building app-admin/gam-server with clang and update EAPI to 7 #13122

Closed
wants to merge 2 commits into from

Conversation

Peter-Levine
Copy link
Contributor

gam-server package is old and outdated and should eventually be removed. But until it is, it might as well support being built with clang. And if so, its EAPI might as well be updated too.

  • Update to EAPI 7
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Peter Levine plevine457@gmail.com

  • Fix building with clang
    In GCC, a void return statement in a function that doesn't return void
    returns 0 as a compatibility measure for archaic K&R C. Reliance on such
    behavior causes failure with clang. Explicitly return the intended
    return variable which is initialized to 0.
    Closes: https://bugs.gentoo.org/509696

Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Peter Levine plevine457@gmail.com

Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Peter Levine <plevine457@gmail.com>
In GCC, a void return statement in a function that doesn't return void
returns 0 as a compatibilty measure for archaic K&R C. Reliance on such
behavior causes failure with clang. Explicitly return the intended
return variable which is initialized to 0.

Closes: https://bugs.gentoo.org/509696
Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Peter Levine <plevine457@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Peter-Levine
Areas affected: ebuilds
Packages affected: app-admin/gam-server

app-admin/gam-server: @gentoo/freedesktop

Linked bugs

Bugs linked: 509696


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 2, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-10-02 02:59 UTC
Newest commit scanned: 9900d52
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/2b037a7/output.html#games-action/crimsonland
https://qa-reports.gentoo.org/output/gentoo-ci/2b037a7/output.html#games-roguelike/neon-chrome

@dpronin
Copy link
Contributor

dpronin commented Mar 15, 2020

Hey, has there been any activity? The PR alike has been opened by me for almost 1 month and nobody taken a look at it. May someone be responsible to finally merge it in in order to cease failing builds with clang as a compiler?

Thank you

@Peter-Levine
Copy link
Contributor Author

@dannftk They have been moving in the direction of removing fam altogether so they may decide not to update fam related ebuilds in the meantime.

@dpronin
Copy link
Contributor

dpronin commented Mar 16, 2020

@Peter-Levine , they have been removing 'fam' too long, haven't they? Do you know who a supreme maintainer is? For you requested the PR last year in October, so far no response has been given, there is silence

@Peter-Levine
Copy link
Contributor Author

fam should be removed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants