Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-cluster/spark-bin: bump from 2.4.3 to 2.4.4 #13159

Closed
wants to merge 3 commits into from
Closed

sys-cluster/spark-bin: bump from 2.4.3 to 2.4.4 #13159

wants to merge 3 commits into from

Conversation

trozamon
Copy link
Contributor

@trozamon trozamon commented Oct 5, 2019

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @trozamon
Areas affected: ebuilds
Packages affected: sys-cluster/spark-bin

sys-cluster/spark-bin: @gentoo/java, @trozamon, @gentoo/proxy-maint

Linked bugs

Bugs linked: 696182

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 5, 2019
@juippis
Copy link
Member

juippis commented Oct 9, 2019

Noo don't use git mv but rather split addition and removal into their separate commits.

@trozamon
sys-cluster/spark-bin: bump 2.4.3 to 2.4.4
2d214bd 
Package-Manager: Portage-2.3.76, Repoman-2.3.16
Signed-off-by: Alec Ten Harmsel <alec@alectenharmsel.com>
Closes: https://bugs.gentoo.org/696182
@trozamon
sys-cluster/spark-bin: remove 2.4.3
d29b534 
Signed-off-by: Alec Ten Harmsel <alec@alectenharmsel.com>
Package-Manager: Portage-2.3.76, Repoman-2.3.16
@trozamon
Copy link
Contributor Author

trozamon commented Oct 9, 2019

Noo don't use git mv but rather split addition and removal into their separate commits.

Ah, ok, I'll remember that for the future. How do the new commits look?

juippis
juippis reviewed Oct 11, 2019
View reviewed changes
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild Outdated
# Copyright 1999-2019 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look much better! Could you however try building it with EAPI-7 updated here? Namely the eclass should support it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - working fine for me. Thank you for all the review.

@trozamon
sys-cluster/spark-bin: update 2.4.4 to EAPI 7
4a1e90a 
Signed-off-by: Alec Ten Harmsel <alec@alectenharmsel.com>
Package-Manager: Portage-2.3.76, Repoman-2.3.16
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-10-11 19:38 UTC
Newest commit scanned: 4a1e90a
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/b7adda0/output.html#net-libs/nodejs
https://qa-reports.gentoo.org/output/gentoo-ci/b7adda0/output.html#sci-mathematics/kodkod

@juippis
Copy link
Member

juippis commented Oct 16, 2019

Thanks!

@trozamon trozamon closed this Oct 18, 2019
@trozamon trozamon deleted the bump-spark-2.4.4 branch October 18, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@trozamon @gentoo-bot @juippis @gentoo-repo-qa-bot