net-irc/telepathy-idle: fix 100% cpu usage and tests #13221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request assignmentSubmitter: @okias net-irc/telepathy-idle: @gentoo/gnome Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
I updated description of Pull from commit. Since my first PullReq there been changes to ebuild. |
okias
changed the title
|
Then please change your git commit message title to describe your major fix accordingly, |
okias
changed the title
Added latest fixes from 0.2.0 branch.
- fixes tests
- fixes extreme CPU usage.
- fixes GCC warning
It's unlikely that new version (0.2.1 nor 1.x) will be released soon, so
it's really good idea merge these patches.
---
In function 'strncpy',
inlined from 'idle_server_connection_send_async' at idle-server-connection.c:593:2:
/usr/include/bits/string_fortified.h:106:10: error: '__builtin_strncpy' specified bound 512 equals destination size [-Werror=stringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
Closes: https://bugs.gentoo.org/636576
Closes: https://bugs.gentoo.org/684832
Signed-off-by: David Heidelberg <david@ixit.cz>
Pull request CI reportReport generated at: 2019-10-27 18:58 UTC No issues found |
|
I dropped the gcc warning fix, because I think that should be investigated and not papered over. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added latest fixes from 0.2.0 branch.
It's unlikely that new version (0.2.1 nor 1.x) will be released soon, so
it's really good idea merge these patches.
Closes: https://bugs.gentoo.org/636576
Closes: https://bugs.gentoo.org/684832
Signed-off-by: David Heidelberg david@ixit.cz