games-emulation/dolphin: added missing dependency

[HWXLR8]

Latest dev build requires media-libs/vulkan-loader
to use vulkan backend.

Package-Manager: Portage-2.3.76, Repoman-2.3.17

[gentoo-bot]

Pull Request assignment

Submitter: @drylemon
Areas affected: ebuilds
Packages affected: games-emulation/dolphin

games-emulation/dolphin: @trofi

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[trofi]

Does the build fail for you otherwise? It does not for me. Can you share the build.log?

[HWXLR8]

@trofi The build doesn't fail, but one of the differences between the stable version, and the 9999 version is the inclusion of dev-util/vulkan-headers for vulkan support, but this alone is not enough to use the vulkan backend, media-libs/vulkan-loader is also required. Should it perhaps be added as a USE flag instead?

[trofi]

It depends on what is broken. I still fail to understand the difference between actual and expected behaviour. Does vulkan option not get enabled? Or you get runtime failure?

Once I understand that I can answer if the proposed solution works.

[HWXLR8]

In the 9999 version, the vulkan backend is an option:

but if you try to select it, you get this error:

emerging media-libs/vulkan-loader resolves this.

[trofi]

Aha, you change looks good almost as-is then.

Can you add a few minor tweaks:

• move the dependency to RDEPEND only (no need to build-time requirement). The syntax would be roughly: RDEPEND="..." DEPEND="${RDEPEND} ..." RDEPEND="${EDEPEND} vulcan-loader
• add a comment to ebuild to explain why it's needed.

I'll merge it then.

[HWXLR8]

@trofi like this?

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2019-10-12 05:37 UTC
Newest commit scanned: 6e0c0b2
Status: ✅ good

No issues found

[trofi]

Looks good! Pushed with a slight whitespace change and comment tweak.

Thank you!