UT2004 Revival #13365
UT2004 Revival #13365
Conversation
Closes: https://bugs.gentoo.org/601402 Package-Manager: Portage-2.3.77, Repoman-2.3.17 Signed-off-by: David Seifert <soap@gentoo.org>
Package-Manager: Portage-2.3.77, Repoman-2.3.17 Signed-off-by: David Seifert <soap@gentoo.org>
Package-Manager: Portage-2.3.77, Repoman-2.3.17 Signed-off-by: David Seifert <soap@gentoo.org>
Package-Manager: Portage-2.3.77, Repoman-2.3.17 Signed-off-by: David Seifert <soap@gentoo.org>
* EAPI 7 * Fetching should work again Bug: https://bugs.gentoo.org/601402 Signed-off-by: David Seifert <soap@gentoo.org>
Pull Request assignmentSubmitter: @SoapGentoo games-fps/ut2004: @gentoo/games Linked bugsBugs linked: 601402 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2019-10-20 22:38 UTC Issues already there before the PR (double-check them): |
| src_prepare() { | ||
| default | ||
|
|
||
| mv -f UT2004MegaPack/* . || die |
|
|
||
| src_install() { | ||
| insinto /opt/ut2004 | ||
| doins -r Animations Help Maps Sounds StaticMeshes System Textures |
There was a problem hiding this comment.
Wouldn't * work here? Especially that there's a lot of rm-ing anyway.
| rm StaticMeshes/{BenMesh02,BenTropicalSM01,HourAdara,ONS-BPJW1,PC_UrbanStatic}.usx || die | ||
|
|
||
| # System | ||
| rm System/{AL,AS-,B,b,C,D,E,F,G,I,L,O,o,S,s,U,V,W,X,x}* || die |
There was a problem hiding this comment.
Yyyyyy, wouldn't a whitelist (i.e. installing files selectively) work better here?
| uz2unpack "${ut_unpack}/${f}" "${ut_unpack}/${f%.uz2}" \ | ||
| || die "uncompressing file ${f}" | ||
| rm -f "${ut_unpack}/${f}" || die "deleting compressed file ${f}" | ||
| done < <(find "${ut_unpack}" -maxdepth 1 -name '*.uz2' -printf '%f\n' 2>/dev/null) |
| done | ||
|
|
||
| make_wrapper ut2004 ./ut2004-bin "${dir}"/System "${dir}"/System "${dir}" | ||
| make_wrapper ut2004 ./ut2004-bin /opt/ut2004/System /opt/ut2004/System /opt/ut2004 | ||
|
|
||
| # Remove unneccessary files |
There was a problem hiding this comment.
You realize that keeping a huge blacklist is just insane?
|
@mgorny, I think all the things you've commented on are issues with the existing ebuild. I think it could be a lot simpler but it's a big job we don't have time for before the last-rite. I may look into it afterwards as I have interest in this game and I do have the DVD. As things stand, it does install for me. |
|
@SoapGentoo, what are you doing about the |
| DESCRIPTION="Editor's Choice Edition plus Mega Pack for the well-known first-person shooter" | ||
| HOMEPAGE="http://www.unrealtournament2004.com/" | ||
| SRC_URI=" | ||
| http://treefort.icculus.org/${PN}/${MY_P} | ||
| http://ut2004.ut-files.com/index.php?dir=Patches/Linux/&file=${MY_P} -> ${MY_P} |
There was a problem hiding this comment.
This can just be https://ut2004.ut-files.com/Patches/Linux/${MY_P}.
|
This is now merged with a bunch of tweaks. Thanks! |
No description provided.