net-dialup/lrzsz: fix compilation with gettext-0.20 #13400
Conversation
Pull Request assignmentSubmitter: @ConiKost net-dialup/lrzsz: @gentoo/embedded Linked bugsBugs linked: 685696 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
ConiKost
force-pushed
the
lrzsz
branch
2 times, most recently
from
a954192
to
48380b1
Compare
Thanks to Felix J. Ogris for the patch! Closes: https://bugs.gentoo.org/685696 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
Pull request CI reportReport generated at: 2019-10-24 10:37 UTC No issues found |
|
Lately there's been a lot of talk in gentoo-dev IRC channel and mailing list about breaking stable ebuilds, and not revbumping when making simple changes like this. This is indeed a fix to a build-breakage, and doesn't seem to affect list of installed files, nor runtime behaviour in any way. Still, it's very much couraged to revbump and reset KEYWORDS nowadays. Rule seems to be, do not touch stable ebuilds. ... however that will just cause the maintainer to have more maintenance work with this one. Ask for re-stabilization on all arches, drop old ebuild, etc. That's why I tested this on ~amd64 and amd64 systems to make sure it's backward-compatible. Let's go with this one. It's a good contribution after all that fixes a bug. I just wanted to say, in future be extra careful with changes like this, when you can commit on your own ;) |
Closes: https://bugs.gentoo.org/685696
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Conrad Kostecki conrad@kostecki.com