Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cargo changes #13440

Closed
wants to merge 3 commits into from
Closed

test cargo changes #13440

wants to merge 3 commits into from

Conversation

gyakovlev
Copy link
Member

No description provided.

Bug: https://bugs.gentoo.org/695698
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
not used anymore

Closes: https://bugs.gentoo.org/695698
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
@gyakovlev gyakovlev added do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. priority-ci Increase the priority for CI processing. Use scarcely. work in progress The PR is not yet ready to be merged. labels Oct 25, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-10-25 22:59 UTC
Newest commit scanned: e243cc1
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/6c728c2/output.html#www-plugins/chrome-binary-plugins

@@ -146,7 +146,7 @@ cargo_src_compile() {

export CARGO_HOME="${ECARGO_HOME}"

cargo build -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
cargo -vv build -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you imagine to make the -vv optional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, changes coming soon.
default will be verbose though.
but it'll be possible to override it back to quiet.
also NOCOLOR will be supported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyakovlev
Copy link
Member Author

closing, took a bit different route

@gyakovlev gyakovlev closed this Dec 31, 2019
@gyakovlev gyakovlev deleted the cargo-changes branch January 2, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. priority-ci Increase the priority for CI processing. Use scarcely. work in progress The PR is not yet ready to be merged.
Projects
None yet
3 participants