app-editors/scite: Version Bump to 4.2.1. #13464

dermoench42 · 2019-10-27T12:14:30Z

Actual enhancements and upstream bugfixes.

Signed-off-by: Ervin Peters ervin.peters@ervnet.de
Package-Manager: Portage-2.3.76, Repoman-2.3.16

Actual enhancements and upstream bugfixes. Signed-off-by: Ervin Peters ervin.peters@ervnet.de Package-Manager: Portage-2.3.76, Repoman-2.3.16

gentoo-bot · 2019-10-27T12:16:11Z

Pull Request assignment

Submitter: @dermoench42
Areas affected: ebuilds
Packages affected: app-editors/scite

app-editors/scite: ~~ervin.peters[at]ervnet.de~~, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

juippis · 2019-10-28T06:47:39Z

app-editors/scite/scite-4.2.1.ebuild

+}
+
+pkg_postinst() {
+	gnome2_icon_cache_update


With EAPI-7 this is xdg_icon_cache_update, the gnome- one doesnt work anymore. Same for one below.

juippis · 2019-10-28T06:49:10Z

app-editors/scite/scite-4.2.1.ebuild

+}
+
+src_install() {
+	emake DESTDIR="${ED}" install


Replace with default, You could add a global DOCS=( ... ) array to install that README file below when calling default here.

not clear to me. The default implementation is:
src_install() {
if [[ -f Makefile ]] || [[ -f GNUmakefile ]] || [[ -f makefile ]] ; then
emake DESTDIR="${D}" install
fi
einstalldocs
}
which differs in DESTDIR Parameter.

Hmm, sure sure, it doesnt matter that much :)

however, it does not work on a prefixed enviroment.

scite/gtk/makefile:32 gnomeprefix:=$(shell pkg-config --variable=prefix $(GTKVERSION) 2>/dev/null)

will lead to double prefixing in the end. ( returns $EPREFIX/usr )

~~one option would be the default emake (DESTDIR="${D}")~~
~~another option would be emake DESTDIR="$D" prefix="$EPREFIX/usr"~~
~~(also needed for the compilation)~~ (link errors on src_compile).

gnome2_icon_cache_update -> xdg_icon_cache_update Signed-off-by: Ervin Peters ervin.peters@ervnet.de Package-Manager: Portage-2.3.76, Repoman-2.3.16

juippis · 2019-10-29T05:57:31Z

app-editors/scite/scite-4.2.1.ebuild

+}
+
+src_install() {
+	emake DESTDIR="${ED}" install


Hmm, sure sure, it doesnt matter that much :)

juippis · 2019-10-29T05:58:21Z

app-editors/scite/scite-4.2.1.ebuild

+		die "Sorry, SCiTE uses C++17 Features and needs >sys-devel/clang-5
+		($(clang-major-version))."
+
+		elif tc-is-gcc; then


One tab too many.

juippis · 2019-10-29T05:58:51Z

app-editors/scite/scite-4.2.1.ebuild

+x11-libs/gdk-pixbuf
+x11-libs/gtk+:3=
+x11-libs/pango
+lua? ( >=dev-lang/lua-5:= )


Lost indentation here.

juippis · 2019-10-29T05:59:18Z

app-editors/scite/scite-4.2.1.ebuild

+
+EAPI=7
+
+inherit gnome2-utils toolchain-funcs xdg-utils


gnome2-utils isnt used anymore, can be dropped. Few styling things, then it looks good to me!

Signed-off-by: Ervin Peters ervin.peters@ervnet.de Package-Manager: Portage-2.3.76, Repoman-2.3.16

gentoo-repo-qa-bot · 2019-10-31T02:58:43Z

Pull request CI report

Report generated at: 2019-10-31 02:58 UTC
Newest commit scanned: 3f5aca5
Status: ✅ good

No issues found

xdch47 · 2019-10-31T16:52:38Z

app-editors/scite/scite-4.2.1.ebuild

+	if ! use lua; then
+		emake_pars+=" NO_LUA=1"
+	fi
+


why not an array?

# prepare make options local emake_pars=("GTK3=1") tc-is-clang && emake_pars+=("CLANG=1") use !lua && emake_pars+=("NO_LUA=1") emake -C "${WORKDIR}/scintilla/gtk" "${emake_pars[@]}" emake "${emake_pars[@]}"

why? kept from previous versions ;). But an array is more clean, sure. I'll change it.

I was waiting for this, but guess you will fix it in the next version bump? :)

Lets not keep this any longer then, thanks!

... scusi... lack of time. Since this was mainly cosmetic i wanted to fix the prefix thing, too. It will be done probably on the next release.

xdch47 · 2019-10-31T16:58:20Z

don't forget to rebase/squash commits (+force push)

xdch47 · 2019-11-09T10:58:35Z

looks like you commited the version

src_install() {
	emake DESTDIR="${ED}" install

which will lead do double prefix ! - the DOCS=(...) & default would have been better (see above)

so, hopefully next bump...

juippis · 2019-11-11T14:28:36Z

@xdch47 your comments were good, thanks. Didn't want to ignore them, but looked like nothing was happening here so I didn't dare to look away any longer. This PR would've been left to rot for months then ;)

But yes, something to remember & fix for the next time...

app-editors/scite: Version Bump to 4.2.1.

a866043

Actual enhancements and upstream bugfixes. Signed-off-by: Ervin Peters ervin.peters@ervnet.de Package-Manager: Portage-2.3.76, Repoman-2.3.16

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Oct 27, 2019

juippis reviewed Oct 28, 2019

View reviewed changes

app-editors/scite: fix icon cache call in src_install

59efec2

gnome2_icon_cache_update -> xdg_icon_cache_update Signed-off-by: Ervin Peters ervin.peters@ervnet.de Package-Manager: Portage-2.3.76, Repoman-2.3.16

juippis reviewed Oct 29, 2019

View reviewed changes

dermoench42 added 2 commits October 31, 2019 03:32

app-editors/scite: cleanup inherit, formatting

62659a1

Signed-off-by: Ervin Peters ervin.peters@ervnet.de Package-Manager: Portage-2.3.76, Repoman-2.3.16

app-editors/scite: more indention fixes

3f5aca5

Signed-off-by: Ervin Peters ervin.peters@ervnet.de Package-Manager: Portage-2.3.76, Repoman-2.3.16

xdch47 reviewed Oct 31, 2019

View reviewed changes

gentoo-bot closed this in 8f9f387 Nov 9, 2019

dermoench42 deleted the app-editors/scite-4.2.1 branch February 1, 2020 08:13

xdch47 mentioned this pull request Feb 8, 2020

app-editors/scite: Version bump to 4.3.2 #14521

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app-editors/scite: Version Bump to 4.2.1. #13464

app-editors/scite: Version Bump to 4.2.1. #13464

dermoench42 commented Oct 27, 2019

gentoo-bot commented Oct 27, 2019

juippis Oct 28, 2019

juippis Oct 28, 2019

dermoench42 Oct 28, 2019

juippis Oct 29, 2019

xdch47 Oct 31, 2019 •

edited

juippis Oct 29, 2019

juippis Oct 29, 2019

juippis Oct 29, 2019

juippis Oct 29, 2019

gentoo-repo-qa-bot commented Oct 31, 2019

xdch47 Oct 31, 2019

dermoench42 Nov 4, 2019 •

edited

juippis Nov 9, 2019

dermoench42 Nov 11, 2019

xdch47 commented Oct 31, 2019

xdch47 commented Nov 9, 2019

juippis commented Nov 11, 2019

app-editors/scite: Version Bump to 4.2.1. #13464

app-editors/scite: Version Bump to 4.2.1. #13464

Conversation

dermoench42 commented Oct 27, 2019

gentoo-bot commented Oct 27, 2019

Pull Request assignment

Linked bugs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xdch47 Oct 31, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Oct 31, 2019

Pull request CI report

Choose a reason for hiding this comment

dermoench42 Nov 4, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xdch47 commented Oct 31, 2019

xdch47 commented Nov 9, 2019

juippis commented Nov 11, 2019

xdch47 Oct 31, 2019 •

edited

dermoench42 Nov 4, 2019 •

edited