Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/diffball: revbump to 1.0.1-r1 for bug 543310 #13471

Merged

Conversation

zmedico
Copy link
Member

@zmedico zmedico commented Oct 27, 2019

Fix stack buffer overflows reported in bug 543310.

Bug: https://bugs.gentoo.org/543310
See: zmedico/diffball#1
Reported-by: Aidan Thornton makosoft@googlemail.com
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Zac Medico zmedico@gentoo.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @zmedico
Areas affected: ebuilds
Packages affected: dev-util/diffball

dev-util/diffball: @rafaelmartins

Linked bugs

Bugs linked: 543310


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 27, 2019
@rafaelmartins
Copy link
Contributor

Hi @zmedico. The patches looks good, thanks for taking care. However, my fork is as official as yours :) Somebody added my fork as the homepage for diffball, but I just imported it from google code for historical reasons, I'm not doing any maintenance on it. There's a repo from Brian with a lot of unreleased patches (https://github.com/ferringb/diffball/), but I don't think that he is still maintaining it either. I think that the best solution would be to promote your fork as the official one, or just drop the patches into $FILESDIR, if you are not willing to maintain the fork either. What do you think?

@zmedico zmedico force-pushed the bug_543310_diffball_stack_buffer_overflows branch 2 times, most recently from 7f696d6 to 41623ef Compare October 27, 2019 23:04
@zmedico
Copy link
Member Author

zmedico commented Oct 27, 2019

Hi @zmedico. The patches looks good, thanks for taking care. However, my fork is as official as yours :) Somebody added my fork as the homepage for diffball, but I just imported it from google code for historical reasons, I'm not doing any maintenance on it. There's a repo from Brian with a lot of unreleased patches (https://github.com/ferringb/diffball/), but I don't think that he is still maintaining it either. I think that the best solution would be to promote your fork as the official one, or just drop the patches into $FILESDIR, if you are not willing to maintain the fork either. What do you think?

Sure, I can maintain the fork. I've updated the ebuild to refer to https://github.com/zmedico/diffball/pull/1.patch instead.

@zmedico zmedico force-pushed the bug_543310_diffball_stack_buffer_overflows branch from eb37eb6 to 092a088 Compare October 27, 2019 23:32
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-10-27 23:38 UTC
Newest commit scanned: 41623ef
Status: ✅ good

No issues found

@zmedico zmedico force-pushed the bug_543310_diffball_stack_buffer_overflows branch 2 times, most recently from b70e39c to a91ea61 Compare October 27, 2019 23:49
Fix stack buffer overflows reported in bug 543310.

Bug: https://bugs.gentoo.org/543310
See: zmedico/diffball#1
Reported-by: Aidan Thornton <makosoft@googlemail.com>
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Zac Medico <zmedico@gentoo.org>
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Zac Medico <zmedico@gentoo.org>
@zmedico zmedico force-pushed the bug_543310_diffball_stack_buffer_overflows branch from a91ea61 to 15b80af Compare October 27, 2019 23:51
@gentoo-bot gentoo-bot merged commit 15b80af into gentoo:master Oct 27, 2019
@zmedico zmedico deleted the bug_543310_diffball_stack_buffer_overflows branch October 28, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants