Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/nitrocli license #13564

Closed
wants to merge 2 commits into from
Closed

Topic/nitrocli license #13564

wants to merge 2 commits into from

Conversation

d-e-s-o
Copy link
Contributor

@d-e-s-o d-e-s-o commented Nov 6, 2019 •
edited

  • app-crypt/nitrocli: Remove 0.2.3-r1 ebuild
  • app-crypt/nitrocli: Adjust LICENSE for 0.2.4 ebuild

@d-e-s-o
app-crypt/nitrocli: Remove 0.2.3-r1 ebuild
81539d6 
This change removes the nitrocli-0.2.3-r1 ebuild. Version 0.2.4 of
the program should be used as there are no known problems with it.

Signed-off-by: Daniel Müller <deso@posteo.net>
@d-e-s-o
app-crypt/nitrocli: Adjust LICENSE for 0.2.4 ebuild
5154720 
This change adjusts the value of LICENSE to include the licenses of all
crates that find their way into the final installed binary.

Closes: https://bugs.gentoo.org/694412
Signed-off-by: Daniel Müller <deso@posteo.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @d-e-s-o
Areas affected: ebuilds
Packages affected: app-crypt/nitrocli

app-crypt/nitrocli: @d-e-s-o, @gentoo/proxy-maint

Linked bugs

Bugs linked: 694412

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 6, 2019
@d-e-s-o
Copy link
Contributor Author

d-e-s-o commented Nov 6, 2019

@gyakovlev, would you mind taking a look at this pull request?

@juippis
Copy link
Member

juippis commented Nov 6, 2019

LGTM, but you need to drop the last commit. Stabilization is done by arch teams, and you have to request it from bugzilla to your package. Just let me know if you need an example how it's done.

I don't mind that the LICENSEs aren't sorted alphabetically, if you have some idea why they are sorted like they are (number of occurrences?).

@d-e-s-o d-e-s-o force-pushed the topic/nitrocli-license branch 2 times, most recently from 8160939 to 5154720 Compare November 6, 2019 15:59
@d-e-s-o
Copy link
Contributor Author

d-e-s-o commented Nov 6, 2019

LGTM, but you need to drop the last commit.

Done. Thanks for the review.

Just let me know if you need an example how it's done.

Yes, if you have a pointer that would be great.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-11-06 18:00 UTC
Newest commit scanned: 5154720
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/08c9b54/output.html#dev-libs/libffi
https://qa-reports.gentoo.org/output/gentoo-ci/08c9b54/output.html#dev-tex/luatex
https://qa-reports.gentoo.org/output/gentoo-ci/08c9b54/output.html#mail-filter/rspamd
https://qa-reports.gentoo.org/output/gentoo-ci/08c9b54/output.html#net-analyzer/iptraf-ng
https://qa-reports.gentoo.org/output/gentoo-ci/08c9b54/output.html#net-analyzer/nagios-core
https://qa-reports.gentoo.org/output/gentoo-ci/08c9b54/output.html#sys-process/cronie

juippis
juippis approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example (first simple one that came across):
https://bugs.gentoo.org/699402

You open a new bug.
Product - Gentoo
Component - Stablization
Keywords: STABLEREQ

You add those arches as CC, where you wish your package to be stabilized on.
CC: select amd64 & x86, press "add arches"

You edit package list to match your package, with version.
Package list: app-crypt/nitrocli-0.2.4

Then leave it to arch teams to do the stabilization.

@gentoo-bot gentoo-bot closed this in 6b0bd17 Nov 7, 2019
@d-e-s-o d-e-s-o deleted the topic/nitrocli-license branch March 26, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@d-e-s-o @gentoo-bot @juippis @gentoo-repo-qa-bot