-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-misc/anydesk: Version bump. #13611
Conversation
cab1755
to
432dfaf
Compare
Pull Request assignmentSubmitter: @jkroonza net-misc/anydesk: @thecb1, @gentoo/proxy-maint Linked bugsBugs linked: 699316 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
anydesk binary is now linked against libxkbfile.so.1, not sure if we should add it to RDEPEND. |
Using ldd there is a boatload of potential dependencies. objdump -p is somewhat more lenient, and it does show a direct dependency on libxkbfile.so.1 so yes, that need to go into RDEPEND ... Anyway, I'm thinking I should be able to put together a quick hack to given any ELF binary be able to find the reverse dependencies in terms of libraries at least. Should make things easier for packaging binary packages (and even perhaps later help to confirm RDEPEND for non-binary). |
So my crude script picked up the following additional dependencies: x11-libs/libXrender These are direct dependencies, in other words, stuff referenced in the anydesk ELF binary itself. It also kicked out sys-libs/glibc but I'm fairly certain we can assume that libc is a given? It also pointed out that your libxcb wasn't in alphabetic order :). I've added both deps and re-pushed. Happy to make available the script somewhere but I'm warning: It's FUGLY. It probably fails in many scenarios. It's probably doesn't pick up all deps. It doesn't deal with USE flags nor slotting. But it's a starting point for packagers I guess. |
432dfaf
to
496558c
Compare
|
||
DESCRIPTION="Feature rich multi-platform remote desktop application" | ||
HOMEPAGE="https://anydesk.com" | ||
SRC_URI="amd64? ( https://download.anydesk.com/linux/${P}-amd64.tar.gz ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not available to download anymore. Could you update, and also check their license if they allow re-distributing the package in our mirrors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
So they move the downloads as new versions become available, thus, according to ebuild(5):
SRC_URI = "https://example.com/path/${P}.tar.gz"
Contains a list of URIs for the required source files. **It can contain multiple
URIs for a single source file**. The list is processed in order if the file was not
As such I've just taken to providing both possible URLs. Hopefully this is done correctly as I've not ever needed this before (it tests out on my laptop).
Bumped to 5.5.0 either way, which uses the "current release" download scheme.
Regarding license, I'm not a lawyer, so my interpretation of the license is that it's unclear whether or not we're allowed to mirror or not. So with a hard-hat on my recommendation is to play it safe and rather error on the side of not mirroring. I'm not seeing anything specifically allowing us to mirror it, nor specifically preclude us from, but there are hints that they expect users to download the software from their own site.
Package-Manager: Portage-2.3.76, Repoman-2.3.16 Closes: https://bugs.gentoo.org/699316 Signed-off-by: Jaco Kroon <jaco@uls.co.za>
496558c
to
1e68394
Compare
Package-Manager: Portage-2.3.76, Repoman-2.3.16
Signed-off-by: Jaco Kroon jaco@uls.co.za
Closes: https://bugs.gentoo.org/699316