Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-misc/anydesk: Version bump. #13611

Closed
wants to merge 1 commit into from
Closed

Conversation

jkroonza
Copy link
Contributor

Package-Manager: Portage-2.3.76, Repoman-2.3.16
Signed-off-by: Jaco Kroon jaco@uls.co.za
Closes: https://bugs.gentoo.org/699316

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 11, 2019
@jkroonza jkroonza changed the title net-misc/anydesk: Version bump. net-misc/anydesk: Version bump. [please reassign] Nov 11, 2019
@gentoo-bot gentoo-bot changed the title net-misc/anydesk: Version bump. [please reassign] net-misc/anydesk: Version bump. Nov 11, 2019
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @jkroonza
Areas affected: ebuilds
Packages affected: net-misc/anydesk

net-misc/anydesk: @thecb1, @gentoo/proxy-maint

Linked bugs

Bugs linked: 699316


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 11, 2019
@thecb1
Copy link
Contributor

thecb1 commented Nov 11, 2019

anydesk binary is now linked against libxkbfile.so.1, not sure if we should add it to RDEPEND.

@jkroonza
Copy link
Contributor Author

anydesk binary is now linked against libxkbfile.so.1, not sure if we should add it to RDEPEND.

Using ldd there is a boatload of potential dependencies. objdump -p is somewhat more lenient, and it does show a direct dependency on libxkbfile.so.1 so yes, that need to go into RDEPEND ...

Anyway, I'm thinking I should be able to put together a quick hack to given any ELF binary be able to find the reverse dependencies in terms of libraries at least. Should make things easier for packaging binary packages (and even perhaps later help to confirm RDEPEND for non-binary).

@jkroonza
Copy link
Contributor Author

So my crude script picked up the following additional dependencies:

x11-libs/libXrender
x11-libs/libxkbfile

These are direct dependencies, in other words, stuff referenced in the anydesk ELF binary itself.

It also kicked out sys-libs/glibc but I'm fairly certain we can assume that libc is a given?

It also pointed out that your libxcb wasn't in alphabetic order :).

I've added both deps and re-pushed.

Happy to make available the script somewhere but I'm warning: It's FUGLY. It probably fails in many scenarios. It's probably doesn't pick up all deps. It doesn't deal with USE flags nor slotting. But it's a starting point for packagers I guess.


DESCRIPTION="Feature rich multi-platform remote desktop application"
HOMEPAGE="https://anydesk.com"
SRC_URI="amd64? ( https://download.anydesk.com/linux/${P}-amd64.tar.gz )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not available to download anymore. Could you update, and also check their license if they allow re-distributing the package in our mirrors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

So they move the downloads as new versions become available, thus, according to ebuild(5):

   SRC_URI = "https://example.com/path/${P}.tar.gz"
          Contains  a  list  of  URIs for the required source files.  **It can contain multiple
          URIs for a single source file**.  The list is processed in order if the file was  not

As such I've just taken to providing both possible URLs. Hopefully this is done correctly as I've not ever needed this before (it tests out on my laptop).

Bumped to 5.5.0 either way, which uses the "current release" download scheme.

Regarding license, I'm not a lawyer, so my interpretation of the license is that it's unclear whether or not we're allowed to mirror or not. So with a hard-hat on my recommendation is to play it safe and rather error on the side of not mirroring. I'm not seeing anything specifically allowing us to mirror it, nor specifically preclude us from, but there are hints that they expect users to download the software from their own site.

Package-Manager: Portage-2.3.76, Repoman-2.3.16
Closes: https://bugs.gentoo.org/699316
Signed-off-by: Jaco Kroon <jaco@uls.co.za>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-11-28 15:23 UTC
Newest commit scanned: 1e68394
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#app-antivirus/clamav-unofficial-sigs
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#dev-lang/rust
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#dev-lang/rust-bin
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#dev-perl/MogileFS-Server
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#mail-filter/rspamd
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#media-gfx/asymptote
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#net-analyzer/iptraf-ng
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#net-analyzer/nagios-core
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#net-dns/avahi
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#net-proxy/squid
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#net-wireless/airspy
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#net-wireless/tempestsdr
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#sys-devel/binutils-hppa64
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#sys-libs/db
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#sys-process/cronie
https://qa-reports.gentoo.org/output/gentoo-ci/ce34477/output.html#x11-misc/tint2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants