sys-block/sas3ircu: version bump to 16 #13656
Conversation
Pull Request assignmentSubmitter: @vpayno sys-block/sas3ircu: @robbat2 Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
| # Copyright 1999-2019 Gentoo Authors | ||
| # Distributed under the terms of the GNU General Public License v2 | ||
|
|
||
| EAPI=5 |
There was a problem hiding this comment.
Generally version bumps should move the ebuild to EAPI=7
| use amd64-fbsd && doexe sas3ircu_rel/sas3ircu/sas3ircu_freebsd_amd64_rel/sas3ircu | ||
| use x86-fbsd && doexe sas3ircu_rel/sas3ircu/sas3ircu_freebsd_i386_rel/sas3ircu | ||
| use x64-solaris || use x86-solaris && doexe sas3ircu_rel/sas3ircu/sas3ircu_solaris_x86_rel/sas3ircu | ||
| use sparc-solaris && doexe sas3ircu_rel/sas3ircu/sas3ircu_solaris_sparc_rel/sas3ircu |
There was a problem hiding this comment.
Maybe this should be cleaned up a but, this is kind of messy
| elog "Please also download 'SAS-3 Integrated RAID Configuration Utility User Guide' (${DISTFILE_DOC}) " | ||
| elog "and also place it into your DISTDIR directory" | ||
| fi | ||
| einfo $SRC_URI |
There was a problem hiding this comment.
Variable references here should be braced
| # between releases. | ||
| dodoc IRCU_MPT_GEN3_Phase${PV}.0-*.pdf | ||
| dodoc README_SAS3IRCU_P${PV}.txt | ||
| use doc && dodoc "${DISTDIR}"/$DISTFILE_DOC |
| # The second number is some sort of internal revision that is inconsistent | ||
| # between releases. | ||
| dodoc IRCU_MPT_GEN3_Phase${PV}.0-*.pdf | ||
| dodoc README_SAS3IRCU_P${PV}.txt |
There was a problem hiding this comment.
setting the DOCS array rather than running dodoc might be cleaner (make sure to call default in src_install)
| DEPEND="" | ||
| RDEPEND="" |
There was a problem hiding this comment.
Empty DEPEND/RDEPEND variables are pointless and should be left out.
This probably should have BDEPEND="app-arch/unzip since it needs to unpack a .zip
|
|
||
| src_unpack() { | ||
| unpack ${DISTFILE_BIN} | ||
| } |
There was a problem hiding this comment.
This should not be necessary, the default src_unpack should unpack everything that appears in SRC_URI
| use amd64 || use x86 && doexe sas3ircu_rel/sas3ircu/sas3ircu_linux_x64_rel/sas3ircu | ||
| use ppc64 && doexe sas3ircu_rel/sas3ircu/sas3ircu_linux_ppc64_rel/sas3ircu | ||
| use amd64-fbsd && doexe sas3ircu_rel/sas3ircu/sas3ircu_freebsd_amd64_rel/sas3ircu | ||
| use x86-fbsd && doexe sas3ircu_rel/sas3ircu/sas3ircu_freebsd_i386_rel/sas3ircu |
There was a problem hiding this comment.
gentoo/FreeBSD is dead, safe to remove those 2 lines above. keywords are already dropped.
| KEYWORDS="-* ~amd64 ~ppc64 ~x86 ~sparc-solaris ~x64-solaris ~x86-solaris" | ||
| IUSE="efi doc" | ||
| RESTRICT="strip fetch mirror" | ||
| DEPEND="" |
There was a problem hiding this comment.
since distfile is zip it should BDEPEND="app-arch/unzip" in EAPI7
| HOMEPAGE="https://www.broadcom.com/products/storage/host-bus-adapters/sas-9300-8e#downloads" | ||
| LICENSE="LSI" | ||
| SLOT="0" | ||
| KEYWORDS="-* ~amd64 ~ppc64 ~x86 ~sparc-solaris ~x64-solaris ~x86-solaris" |
There was a problem hiding this comment.
Why is there -* here? drop it
vpayno
force-pushed
the
sas3ircu-16
branch
6 times, most recently
from
dc9b583
to
b91323a
Compare
|
Noticed that the amd64 and x86 binaries are for different architectures. Fixed. Installing the arm64 binary and efi file for arm64 (will make a keyword request). |
Signed-off-by: Victor Payno <vpayno+gentoo@gmail.com>
| inherit mount-boot | ||
|
|
||
| DESCRIPTION="LSI MPT-SAS3 controller management tool" | ||
| HOMEPAGE="https://www.broadcom.com/products/storage/host-bus-adapters/sas-9300-8e#downloads" |
There was a problem hiding this comment.
add an empty line after HOMEPAGE
| LICENSE="LSI" | ||
| SLOT="0" | ||
| KEYWORDS="~amd64 ~ppc64 ~x86 ~sparc-solaris ~x64-solaris ~x86-solaris" | ||
| IUSE="doc efi" |
Fixes: #13656 (review) Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
@zmedico @gyakovlev @chutz