Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-video/vdr and 5 plugins: version bump #13716

Closed
wants to merge 6 commits into from

Conversation

madmartin
Copy link
Contributor

media-video/vdr: version bump to 2.4.1
media-plugins/vdr-dvbapi: version bump to 2.2.5
media-plugins/vdr-iptv: version bump to 2.4.0
media-plugins/vdr-femon: version bump to 2.4.0
media-plugins/vdr-skinsoppalusikka: version bump to 2.4.0
media-plugins/vdr-satip: version bump to 2.4.0_p20190208

new generation of media-video/vdr
note: many plugins also need version bumps to work with >=vdr-2.4

Bug: https://bugs.gentoo.org/696746
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Martin Dummer martin.dummer@gmx.net

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @madmartin
Areas affected: ebuilds
Packages affected: media-plugins/vdr-dvbapi, media-plugins/vdr-femon, media-plugins/vdr-iptv, media-plugins/vdr-satip, media-plugins/vdr-skinsoppalusikka...

media-plugins/vdr-dvbapi: @madmartin, @gentoo/proxy-maint
media-plugins/vdr-femon: @gentoo/vdr
media-plugins/vdr-iptv: @gentoo/vdr
media-plugins/vdr-satip: @madmartin, @gentoo/proxy-maint, @gentoo/vdr
media-plugins/vdr-skinsoppalusikka: @gentoo/vdr
media-video/vdr: @madmartin, @gentoo/proxy-maint, @gentoo/vdr

Linked bugs

Bugs linked: 696746


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 19, 2019
new generation of media-video/vdr
note: many plugins also need version bumps to work
with >=vdr-2.4

Bug: https://bugs.gentoo.org/696746
Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
vdr-satip-2.4.0_p20190208 is needed for >vdr-2.4

Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
vdr-skinsoppalusikka-2.4.0 is needed for >vdr-2.4

Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
vdr-femon-2.4.0 is needed for >vdr-2.4

Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
vdr-iptv-2.4.0 is needed for >vdr-2.4

Package-Manager: Portage-2.3.78, Repoman-2.3.17
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
vdr-dvbapi-2.2.5 is needed for >vdr-2.4

Package-Manager: Portage-2.3.79, Repoman-2.3.17
Signed-off-by: Martin Dummer <martin.dummer@gmx.net>

MY_P="vdr-plugin-dvbapi-${PV}"

DESCRIPTION="VDR Plugin: allows connect VDR to OScam"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description seems a bit weird... maybe clarify it a bit with good english?

Comment on lines +22 to +23
|| ( dev-libs/tinyxml
dev-libs/pugixml )"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort :P

Comment on lines +19 to +22
virtual/jpeg:*
sys-libs/libcap
>=media-libs/fontconfig-2.4.2
>=media-libs/freetype-2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort.

$ LC=C sort
	>=media-libs/fontconfig-2.4.2
	>=media-libs/freetype-2
	sys-libs/libcap
	virtual/jpeg:*

Comment on lines +27 to +28
>=media-tv/gentoo-vdr-scripts-2.7
media-fonts/corefonts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort.


# checking for s2api headers
local api_version
api_version=$(awk -F' ' '/define DVB_API_VERSION / {print $3}' "${DVBDIR}"/linux/dvb/version.h)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| die

# checking for s2api headers
local api_version
api_version=$(awk -F' ' '/define DVB_API_VERSION / {print $3}' "${DVBDIR}"/linux/dvb/version.h)
api_version=${api_version}*$(awk -F' ' '/define DVB_API_VERSION_MINOR / {print $3}' "${DVBDIR}"/linux/dvb/version.h)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sam here, inside subshell btw.

eapply "${FILESDIR}/vdr-2.2.0-jpeg-9c.patch"
use demoplugins || eapply "${FILESDIR}/vdr-2.4_remove_plugins.patch"
eapply "${FILESDIR}/vdr-makefile-variables.patch"
use naludump && eapply "${DISTDIR}/vdr-2.1.5-naludump-0.1.diff"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be applied unconditionally? Will it break something if naludump isn't being used?

Since we really dislike conditional patching.


eapply "${FILESDIR}/${P}_gentoo.patch"
eapply "${FILESDIR}/vdr-2.2.0-jpeg-9c.patch"
use demoplugins || eapply "${FILESDIR}/vdr-2.4_remove_plugins.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@madmartin
Copy link
Contributor Author

manual close, ebuilds committed by hd_brummy@gentoo.org

@madmartin madmartin closed this Dec 27, 2019
@madmartin madmartin deleted the vdr-2.4 branch December 27, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants