Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-emulation/libpod: Add missing seccomp.json and crun runtime dep #13743

Closed
wants to merge 1 commit into from

Conversation

BinaryKhaos
Copy link
Contributor

seccomp.json needs to be installed in /usr/share/containers and will be used by libpod as well as buildah. Without it, some containers will not work due to seccomp usage that is otherwise blocked.

Fedora has switched to crun as the default container runtime. At the moment it is the only runtime that supports CGroup v2 which in-turn greatly helps with rootless mode. Support crun as an alternative to
the runc dependency.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @BinaryKhaos
Areas affected: ebuilds
Packages affected: app-emulation/libpod

app-emulation/libpod: @zmedico

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Nov 23, 2019
@BinaryKhaos
Copy link
Contributor Author

Ah, sorry. While I was doing some last minute rewriting, somehow the sign-off get lost along the way. I just noticed it now. I will update it tomorrow. Sorry again!

seccomp.json needs to be installed in /usr/share/containers and will
be used by libpod as well as buildah. Without it, some containers
will not work due to seccomp usage that is otherwise blocked.

Fedora has switched to crun as the default container runtime. At the
moment it is the only runtime that supports CGroup v2 which in-turn
greatly helps with rootless mode. Support crun as an alternative to
the runc dependency.

Package-Manager: Portage-2.3.79, Repoman-2.3.18
Signed-off-by: Matthias Dahl <matthias.dahl@binary-island.eu>
@BinaryKhaos
Copy link
Contributor Author

Ok, signed-off is now added back. Sorry again!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-11-24 08:41 UTC
Newest commit scanned: fd37f9d
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-admin/consul
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-admin/consul-template
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-admin/vault
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-antivirus/clamav-unofficial-sigs
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-emulation/docker
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-emulation/docker-compose
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-emulation/lxd
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-emulation/reg
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-laptop/hdaps-gl
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#app-metrics/blackbox_exporter
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-db/mariadb
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-db/pgbouncer
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-db/postgresql
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-lang/php
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-lang/rust
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-lang/rust-bin
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-perl/MogileFS-Server
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-php/pecl-http
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-php/pecl-redis
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-python/oslo-utils
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-python/prometheus_client
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-ruby/facter
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#dev-util/jenkins-bin
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#mail-filter/rspamd
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#media-libs/assimp
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#media-libs/coin
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-analyzer/nagios-core
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-analyzer/wireshark
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-dns/avahi
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-dns/unbound
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-mail/notmuch
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-misc/apt-cacher-ng
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-misc/dropbear
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-misc/gerbera
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-misc/memcached
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-misc/scponly
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-proxy/squid
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#net-vpn/tor
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-apps/guix
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-cluster/galera
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-cluster/kube-apiserver
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-cluster/kube-controller-manager
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-cluster/kube-scheduler
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-cluster/nova
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-devel/binutils-hppa64
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#sys-process/cronie
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#www-apps/grafana-bin
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#www-apps/netbox
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#www-servers/nginx
https://qa-reports.gentoo.org/output/gentoo-ci/649d78b/output.html#x11-libs/fltk

@zmedico
Copy link
Member

zmedico commented Nov 24, 2019

Merged in 69fa809. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants