sys-libs/libcxx-9.0.0: fix error when compiling with clang+compiler-rt #13748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-bot
added
assigned
geraint0923
force-pushed
the
fix_libcxx
branch
from
afccf39
to
1f4a93a
Compare
geraint0923
changed the title
gentoo-bot
changed the title
gentoo-bot
added
assigned
geraint0923
force-pushed
the
fix_libcxx
branch
from
1f4a93a
to
ca95c79
Compare
geraint0923
changed the title
gentoo-bot
changed the title
gentoo-bot
added
assigned
mgorny
requested changes
Nov 24, 2019
geraint0923
force-pushed
the
fix_libcxx
branch
3 times, most recently
from
bc1222a
to
285593f
Compare
Addressed the comment, please take a look. |
mgorny
reviewed
Nov 24, 2019
According to https://clang.llvm.org/docs/Toolchain.html#compiler-rt-llvm, `-DLIBCXXABI_USE_COMPILER_RT=YES` is needed to linked against compiler-rt if compiled with clang+compiler-rt. Signed-off-by: Yang Yang <geraint0923@gmail.com>
According to https://clang.llvm.org/docs/Toolchain.html#compiler-rt-llvm, `-DLIBCXX_USE_COMPILER_RT=YES` is needed to linked to compiler-rt. Otherwise building libcxx using clang+compiler-rt will fail. Signed-off-by: Yang Yang <geraint0923@gmail.com>
geraint0923
force-pushed
the
fix_libcxx
branch
from
285593f
to
687236a
Compare
geraint0923
changed the title
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @geraint0923 sys-libs/libcxx: Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://clang.llvm.org/docs/Toolchain.html#compiler-rt-llvm,
-DLIBCXX_USE_COMPILER_RT=YESand-DLIBCXXABI_USE_COMPILER_RT=YESare explicitly needed to compile with clang+compiler-rt.Otherwise libcxx will fail to build due to error like:
undefined reference to '__udivdi3'