New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-lang/erlang: introduce subslots #13780
Conversation
Pull Request assignmentSubmitter: @arkamar dev-erlang/ezlib: At least one of the listed packages is maintained entirely by non-GitHub developers! Linked bugsBugs linked: 661080, 692294, 700260, 661126 Missing Bugzilla accountsWARNING: The following maintainers do not match any Bugzilla accounts: Please either fix the e-mail addresses in metadata.xml or create a Bugzilla account, and request reassignment afterwards. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
The changes look mostly ok. The motivation behind subslot for I suggest stating the subslot motivation right in the ebuild in comment.
AFAIU erlang does not perform such a code duplication and just uses bytecode (and maybe something else with
I suspect some form of |
Yes, I will look at it for sure. I just wanted to let you know that you can count with it. |
I found Support, Compatibility, Deprecations, and Removal document, where section 6.3 describes what we need. I believe those two points are most important:
I believe we should use The HiPE seems to be safe to use only with Well, some projects can start with User-Defined Boot Script and those relies on exact application versions in OTP, but it seems that we do not have any package with this in What do you think? |
Gentoo has no way to set programmatic |
Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Bug: https://bugs.gentoo.org/661080 Bug: https://bugs.gentoo.org/661126 Bug: https://bugs.gentoo.org/692294 Bug: https://bugs.gentoo.org/700260 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Bug: https://bugs.gentoo.org/661080 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Bug: https://bugs.gentoo.org/661126 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Bug: https://bugs.gentoo.org/661126 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Closes: https://bugs.gentoo.org/700260 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
75993c5
to
0bf94fa
Compare
Done and rebased on top of current |
thanks! |
This PR introduces subslots in erlang and subscribes few packages to it.
I believe we should support subslots in erlang in similar fashion like
dev-lang/go
for example. I have chosen0/${PV}
because time to time it happens that patch version fixes some bugs in compiler and therefore we want to recompile all erlang dependent packages.Well, I am not sure if this is a correct way how to introduce subslots to any package, but I did not find any satisfactory guidelines. Please, tell me what do you think.