Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-arch/innoextract: Bump to version 1.5 #138

Merged
merged 2 commits into from
Sep 29, 2015
Merged

app-arch/innoextract: Bump to version 1.5 #138

merged 2 commits into from
Sep 29, 2015

Conversation

dscharrer
Copy link
Contributor

No description provided.

@dscharrer dscharrer changed the title Bump to version 1.5 app-arch/innoextract: Bump to version 1.5 Sep 28, 2015
@jlec
Copy link
Contributor

jlec commented Sep 28, 2015

@hasufell for you.

@mgorny mgorny added version bump assigned PR successfully assigned to the package maintainer(s). labels Sep 28, 2015
hasufell
hasufell reviewed Sep 29, 2015
View reviewed changes
app-arch/innoextract/innoextract-1.5.ebuild
@@ -0,0 +1,69 @@
# Copyright 1999-2013 Gentoo Foundation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be # Copyright 1999-2015 Gentoo Foundation

@dscharrer
Copy link
Contributor Author

I've updated the commits with the requested changes.

I don't really care about subslots so I've left them out for now (the 1.4 ebuild doesn't have them).

@hasufell
Copy link
Contributor

@mgorny ...I don't have a very strong opinion on subslots, but it's a little bit strong, so you will have to come up with something that convinces me to do more maintenance work on my machine (subslots cause more maintenance work on paludis)

hasufell
hasufell reviewed Sep 29, 2015
View reviewed changes
app-arch/innoextract/innoextract-1.5.ebuild

EAPI=5

inherit cmake-utils eutils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usex is part of EAPI=5 so it seems we don't even need eutils anymore

@dscharrer
Copy link
Contributor Author

Updated again with eutils removed

@hasufell
Copy link
Contributor

Please remove <herd>proxy-maintainers</herd> from metadata.xml, because you can ping me directly or via github. No need for them to be involved.

@dscharrer
Copy link
Contributor Author

Done.

@gentoo-bot gentoo-bot merged commit 20d64fa into gentoo:master Sep 29, 2015
hasufell pushed a commit that referenced this pull request Sep 29, 2015
Merge branch 'master' of git://github.com/dscharrer/gentoo
fe38c71 
This bumps app-arch/innoextract to version 1.5.

Reviewed-By: Julian Ospald <hasufell@gentoo.org>
Reviewed-By: Michał Górny <mgorny@gentoo.org>

Github-PR: #138
@hasufell
Copy link
Contributor

sub-slot added in cd001c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
Milestone
No milestone
5 participants
@dscharrer @jlec @hasufell @mgorny @gentoo-bot