Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-apps/debianutils: Introduce USE=systemd-boot #13879

Closed
wants to merge 1 commit into from

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Dec 5, 2019

Introduce a 'systemd-boot' flag to toggle symlinking systemd's kernel-
install to installkernel, rather than installing the standard Debian
script. This makes the kernel's 'make install' target use systemd-boot
install layout.

While technically this could be introduced separately (e.g. a separate
package requiring sys-apps/debianutils[-installkernel]), adding it
as a USE flag involves much less complexity and improves visibility.
In particular, it makes it possible to toggle the option via one USE
flag switch vs having to do some external action plus disable
installkernel flag.

Signed-off-by: Michał Górny mgorny@gentoo.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mgorny
Areas affected: ebuilds, profiles
Packages affected: sys-apps/debianutils

sys-apps/debianutils: @gentoo/base-system

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Dec 5, 2019
@floppym
Copy link
Contributor

floppym commented Dec 5, 2019

The symlink crossing the /usr boundary might cause issues with merged-usr systems. In that scenario, if the user calls /usr/sbin/installkernel, the kernel will try to resolve that as /usr/sbin/../usr/bin/kernel-install, which won't actually exist.

Maybe it would be better to add an "installkernel" USE flag to sys-apps/systemd and sys-apps/systemd-boot to install this symlink instead. We could utilize the rootprefix logic already present there.

@mgorny
Copy link
Member Author

mgorny commented Dec 5, 2019

That defeats both the primary goal of not requiring the user to alter flags on two packages, and involves huge rebuild in order to switch one symlink.

@floppym
Copy link
Contributor

floppym commented Dec 5, 2019

I really don't think this is the right way to handle this. NAK from me.

Introduce a 'systemd-boot' flag to toggle symlinking systemd's kernel-
install to installkernel, rather than installing the standard Debian
script.  This makes the kernel's 'make install' target use systemd-boot
install layout.

While technically this could be introduced separately (e.g. a separate
package requiring sys-apps/debianutils[-installkernel]), adding it
as a USE flag involves much less complexity and improves visibility.
In particular, it makes it possible to toggle the option via one USE
flag switch vs having to do some external action plus disable
installkernel flag.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
Copy link
Member Author

mgorny commented Dec 5, 2019

All done.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-12-05 22:18 UTC
Newest commit scanned: 09ae2e7
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/consul
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/consul-template
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/diradm
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/graylog
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/puppet
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/puppet-agent
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/puppetdb
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/puppetserver
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-admin/vault
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-antivirus/clamav
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-antivirus/clamav-unofficial-sigs
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-emulation/docker
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-emulation/lxd
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-emulation/reg
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-emulation/virtualbox-additions
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-emulation/virtualbox-guest-additions
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-emulation/virtualbox-modules
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-eselect/eselect-opencl
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-metrics/blackbox_exporter
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-metrics/collectd
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#app-metrics/mongodb_exporter
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-db/etcd
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-db/mariadb
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-db/pgbouncer
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-db/postgresql
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-java/icedtea
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-lang/php
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-libs/leatherman
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-libs/libuv
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-perl/MogileFS-Server
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-php/pecl-apcu_bc
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-php/pecl-http
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-php/pecl-redis
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-python/networkx
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-python/subprocess32
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-util/cmt
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-util/coccinelle
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-util/jenkins-bin
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#dev-vcs/python-gitlab
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#mail-filter/rspamd
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#media-gfx/evoluspencil
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#media-gfx/iscan
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#media-libs/bcg729
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-analyzer/munin
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-analyzer/nagios-core
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-analyzer/wireshark
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-dns/avahi
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-dns/bind
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-dns/pdns
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-dns/unbound
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-libs/nodejs
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/apt-cacher-ng
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/dropbear
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/gerbera
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/kea
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/memcached
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/rabbitmq-server
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/scponly
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-misc/stunnel
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-proxy/haproxy
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-proxy/squid
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-vpn/tor
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#net-wireless/kismet
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sci-libs/tensorflow
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sci-mathematics/rstudio
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-apps/guix
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-apps/policycoreutils
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-cluster/galera
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-cluster/kube-apiserver
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-cluster/kube-controller-manager
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-cluster/kube-scheduler
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-cluster/nova
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-fs/zfs
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#sys-process/cronie
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#www-apps/grafana-bin
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#www-apps/netbox
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#www-apps/zeppelin-bin
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#www-servers/nginx
https://qa-reports.gentoo.org/output/gentoo-ci/931254c/output.html#x11-wm/xpra

@mgorny mgorny added the do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. label Dec 6, 2019
@mgorny
Copy link
Member Author

mgorny commented Dec 6, 2019

I have given it some more thought and I'd like to discuss the problem in a wider scope first. I'll file a bug for that.

@mgorny
Copy link
Member Author

mgorny commented Dec 6, 2019

@mgorny mgorny closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants