New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-apps/debianutils: Introduce USE=systemd-boot #13879
Conversation
Pull Request assignmentSubmitter: @mgorny sys-apps/debianutils: @gentoo/base-system Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
The symlink crossing the /usr boundary might cause issues with merged-usr systems. In that scenario, if the user calls Maybe it would be better to add an "installkernel" USE flag to sys-apps/systemd and sys-apps/systemd-boot to install this symlink instead. We could utilize the rootprefix logic already present there. |
That defeats both the primary goal of not requiring the user to alter flags on two packages, and involves huge rebuild in order to switch one symlink. |
I really don't think this is the right way to handle this. NAK from me. |
Introduce a 'systemd-boot' flag to toggle symlinking systemd's kernel- install to installkernel, rather than installing the standard Debian script. This makes the kernel's 'make install' target use systemd-boot install layout. While technically this could be introduced separately (e.g. a separate package requiring sys-apps/debianutils[-installkernel]), adding it as a USE flag involves much less complexity and improves visibility. In particular, it makes it possible to toggle the option via one USE flag switch vs having to do some external action plus disable installkernel flag. Signed-off-by: Michał Górny <mgorny@gentoo.org>
1a568ef
to
09ae2e7
Compare
All done. |
I have given it some more thought and I'd like to discuss the problem in a wider scope first. I'll file a bug for that. |
Introduce a 'systemd-boot' flag to toggle symlinking systemd's kernel-
install to installkernel, rather than installing the standard Debian
script. This makes the kernel's 'make install' target use systemd-boot
install layout.
While technically this could be introduced separately (e.g. a separate
package requiring sys-apps/debianutils[-installkernel]), adding it
as a USE flag involves much less complexity and improves visibility.
In particular, it makes it possible to toggle the option via one USE
flag switch vs having to do some external action plus disable
installkernel flag.
Signed-off-by: Michał Górny mgorny@gentoo.org