Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www apps/gitea: bump to 1.10.1 and remove 1.8.3 #13906

Closed
wants to merge 2 commits into from
Closed

www apps/gitea: bump to 1.10.1 and remove 1.8.3 #13906

wants to merge 2 commits into from

Conversation

xdch47
Copy link
Contributor

@xdch47 xdch47 commented Dec 7, 2019 •
edited

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 7, 2019
@ulm
Copy link
Member

ulm commented Dec 7, 2019

This still doesn't appear to completely address the license issue of bug 694356, as far as github.com/couchbase/goutils/LICENSE.md is concerned.

@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019 •
edited

Sorry forgot the background history:

I think it should accentually have been closed by #12597.
Summary of the discussion there:

  1. upstream clearified license couchbase/goutils@b496390
  2. the orginal files used by gitea do have all an Apache 2.0 license header, see:

Last but not least the LICENSE ITSELF:

License Grant. Couchbase Inc. hereby grants Licensee, free of charge,
the non-exclusive right to use, copy, merge, publish, distribute, sublicense,
and/or sell copies of the Software, and to permit persons 
to whom the Software is furnished to do so, subject to Licensee
including the following copyright notice in all copies
or substantial portions of the Software:

Couchbase (r) http://www.Couchbase.com Copyright 2016 Couchbase, Inc.

I'm not a license expert nor a lawyer, however with my minimal understanding I can not see any incompatibility to the Apache 2.0 license, except its declaration as "End-User Licence Agreement" - however the text is quite “permissive”, isn't it?

@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019 •
edited

however, you are right - I'll try get this changed in Gitea upstream as well to kill all doubts.

@ulm
Copy link
Member

ulm commented Dec 7, 2019

I'm not a license expert nor a lawyer, however with my minimal understanding I can not see any incompatibility to the Apache 2.0 license, except its declaration as "End-User Licence Agreement" - however the text is quite “permissive”, isn't it?

It is not at all permissive, but fundamentally non-free: It neither allows distribution of the source code (the license says that "'Software' means the object code"), nor does it allow distribution of modified versions.

See also bug 694356 comment 3:

https://github.com/go-gitea/gitea/blob/master/vendor/github.com/couchbase/goutils/LICENSE.md

This is non-free:

  • Clause 1 doesn't grant freedom 3 (no right to distribute modified versions).
  • By the paragraph following clause 1, only distribution of object code is allowed (no freedom 1, access to source code).
  • Clause 2 forbids reverse engineering.

However, it isn't the typical language used in an EULA, so I don't believe that it belongs in that group.

@xdch47 xdch47 mentioned this pull request Dec 7, 2019
Closed
@ulm
Copy link
Member

ulm commented Dec 7, 2019

however, you are

Well, I am not a lawyer. :)

I'll try get this changed in Gitea upstream as well to kill all doubts.

Indeed, that would be the best solution.

@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019 •
edited

funny - I see quite tricky to deal with theses licenses (it not merging a kind of modification?)
the clause 2/3 seems to be nonsense in this case… ^^
however the most confusion point for me is the that the files, which are taken from the couchbase/goutils repo all have a apache to license header

@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019 •
edited

another question… the upstream license seems to be just an template, or am i wrong?

LICENSE.md:189 Copyright {yyyy} {name of copyright owner}

should that be something like Copyright 2016-2019 Couchbase, Inc.

@Dessa
Copy link
Contributor

Dessa commented Dec 7, 2019

does DRONE_TAG actually work on your end? i am stuck with 1.9.0-dev and have yet to find the right way to change that.

@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019

no it does not - never saw this since I disabled the showing version.

@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019

@Dessa could you please try the update version here ?

@xdch47 xdch47 force-pushed the www-apps/gitea branch 2 times, most recently from f0a1b06 to e64e041 Compare December 7, 2019 22:24
@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019 •
edited

fixed mistakes (hopefully)

@Dessa
Copy link
Contributor

Dessa commented Dec 7, 2019

Gitea version 1.10.1 built with GNU Make 4.2.1, go1.13.4 : bindata, pam

thanks!

@xdch47
Copy link
Contributor Author

xdch47 commented Dec 7, 2019

thank you !!

@xdch47 xdch47 changed the title www apps/gitea: bump to 1.10.1 and remove 1.8.3 www apps/gitea: bump to 1.10.1 and remove 1.8.3 [please reassign] Dec 10, 2019
@gentoo-bot gentoo-bot changed the title www apps/gitea: bump to 1.10.1 and remove 1.8.3 [please reassign] www apps/gitea: bump to 1.10.1 and remove 1.8.3 Dec 10, 2019
@xdch47
Copy link
Contributor Author

xdch47 commented Dec 10, 2019

  • remove closing license bug
  • fix passing of LDFLAGS
  • fix default file locations

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xdch47
Areas affected: ebuilds
Packages affected: www-apps/gitea

www-apps/gitea: @nemunaire, @gentoo/proxy-maint

Linked bugs

Bugs linked: 702192, 689748

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 10, 2019
@xdch47
www-apps/gitea: bump to 1.10.1
6d546e0 
Closes: https://bugs.gentoo.org/689748
Closes: https://bugs.gentoo.org/702192

Package-Manager: Portage-2.3.80, Repoman-2.3.20
Signed-off-by: Felix Neumärker <xdch47@posteo.de>
@xdch47
www-apps/gitea: remove 1.8.3
01b4bbe 
Package-Manager: Portage-2.3.80, Repoman-2.3.20
Signed-off-by: Felix Neumärker <xdch47@posteo.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-12-10 13:59 UTC
Newest commit scanned: 01b4bbe
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#app-admin/diradm
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#app-emulation/virtualbox-additions
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#app-emulation/virtualbox-modules
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#app-eselect/eselect-opencl
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-db/postgresql
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-java/icedtea
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-lang/php
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-libs/leatherman
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-libs/libuv
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-perl/Archive-Tar-Stream
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-php/pecl-apcu_bc
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-php/pecl-http
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-php/pecl-redis
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-python/networkx
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-python/subprocess32
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-util/cmt
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-util/coccinelle
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#dev-vcs/python-gitlab
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#media-gfx/evoluspencil
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#media-gfx/iscan
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#media-libs/bcg729
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#net-dns/avahi
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#net-dns/pdns
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#net-libs/nodejs
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#net-misc/gerbera
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#net-vpn/tor
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#sci-libs/tensorflow
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#sci-mathematics/rstudio
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#sys-apps/policycoreutils
https://qa-reports.gentoo.org/output/gentoo-ci/5376392/output.html#x11-misc/picom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
6 participants
@xdch47 @ulm @Dessa @gentoo-bot @gentoo-repo-qa-bot @juippis