media-gfx/pencil: Version Bump to 0.6.4 #13947
Conversation
Closes: https://bugs.gentoo.org/684356 Package-Manager: Portage-2.3.81, Repoman-2.3.20 Signed-off-by: Raimund Mathis <iba68@mail.ch> Package-Manager: Portage-2.3.81, Repoman-2.3.20
gentoo-bot
added
maintainer-needed
| @@ -40,7 +40,7 @@ src_install() { | |||
| einstalldocs | |||
|
|
|||
| # install target not yet provided | |||
| # emake INSTALL_ROOT="${D}" install | |||
| # emake INSTALL_ROOT="${D}" install || die "emake install failed" | |||
There was a problem hiding this comment.
emake does not require || die as the eclass handles it. So, the original comment is valid.
Closes: https://bugs.gentoo.org/684356 Package-Manager: Portage-2.3.81, Repoman-2.3.20 Signed-off-by: Raimund Mathis iba68@mail.ch Package-Manager: Portage-2.3.81, Repoman-2.3.20
mundis
changed the title
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @mundis media-gfx/pencil: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 684356 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
| <maintainer type="person"> | ||
| <email>iba68@mail.ch</email> | ||
| <name>Raimund Mathis</name> | ||
| </maintainer> | ||
| <maintainer type="project"> | ||
| <email>proxy-maint@gentoo.org</email> | ||
| <name>Proxy Maintainers</name> | ||
| </maintainer> |
There was a problem hiding this comment.
Replace the <!-- maintainer needed --> section with this info, ie put this on top of <upstream> and remove maintainer-needed.
| @@ -1,4 +1,4 @@ | |||
| # Copyright 1999-2018 Gentoo Foundation | |||
| # Copyright 1999-2019 Gentoo Authors | |||
There was a problem hiding this comment.
There's no reason at all for you to even touch this ebuild.
|
|
||
| EAPI=7 | ||
|
|
||
| inherit desktop l10n qmake-utils xdg-utils |
There was a problem hiding this comment.
You should drop l10n.eclass and install all locales by default, this is now on user to INSTALL_MASK these unwanted small files. I don't really mind it, but it's the right thing to do.
| inherit desktop l10n qmake-utils xdg-utils | ||
|
|
||
| DESCRIPTION="2D animation and drawing program based on Qt5" | ||
| HOMEPAGE="https://www.pencil2d.org/" |
There was a problem hiding this comment.
You could add the Github page here as well.
| PLOCALES="ca cs da de el es et fr he hu_HU id it ja kab pl pt pt_BR ru sl vi zh_CN zh_TW" | ||
|
|
||
| RDEPEND=" | ||
| dev-qt/qtcore:5 |
There was a problem hiding this comment.
You seem to be missing some of the required deps here. You should really study upstream build files to detect how they're used and what are unconditionally required. I see a potential for doc USE flag for example, then there's something for ffmpeg and at least qtxmlpatterns is required to build this program.
|
|
||
| insinto /usr/share/mime/packages/ | ||
| doins app/data/pencil2d.xml | ||
| dodoc LICENSE.TXT |
There was a problem hiding this comment.
No need to duplicate GPL-2 license. Calling einstalldocs above is enough.
|
why close it? |
Closes: https://bugs.gentoo.org/684356
Package-Manager: Portage-2.3.81, Repoman-2.3.20
Signed-off-by: Raimund Mathis iba68@mail.ch
Package-Manager: Portage-2.3.81, Repoman-2.3.20