kde-misc/plasma-applet-window-title and kde-misc/plasma-applet-window-buttons: New packages #14039
Conversation
Pull Request assignmentSubmitter: @fedeliallalinea kde-misc/plasma-applet-window-buttons: @gentoo/proxy-maint (new package) Linked bugsBugs linked: 703298 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
| MY_PN="${PN/plasma-/}" | ||
|
|
||
| if [[ ${PV} == "9999" ]] ; then | ||
| inherit git-r3 kde5 |
There was a problem hiding this comment.
Please don't use kde5.eclass anymore:
This eclass is *deprecated*. Please read the PORTING notes for switching to ecm.eclass in case the package is using extra-cmake-modules, otherwise just use cmake-utils.eclass instead. For projects hosted on kde.org infrastructure, inherit kde.org.eclass to fetch and unpack sources independent of the build system being used.
For inspiration on how to do it, look at latte-dock-0.9.5.ebuild for example.
| HOMEPAGE="https://github.com/psifidotos/applet-window-buttons" | ||
|
|
||
| LICENSE="GPL-2+" | ||
| IUSE="" |
There was a problem hiding this comment.
When porting away from kde5.eclass, SLOT would be missing below LICENSE.
| IUSE="" | ||
|
|
||
| DEPEND=" | ||
| $(add_frameworks_dep extra-cmake-modules) |
There was a problem hiding this comment.
If you use kde5.eclass or ecm.eclass, this dependency is added automatically for you.
| LICENSE="GPL-2+" | ||
| IUSE="" | ||
|
|
||
| DEPEND=" |
There was a problem hiding this comment.
Looking at https://github.com/psifidotos/applet-window-buttons/blob/master/libappletdecoration/CMakeLists.txt there should be much more dependencies, e.g. Qt is missing completely. Did you check linking with lddtree?
| MY_PN="${PN/plasma-/}" | ||
|
|
||
| if [[ ${PV} == "9999" ]] ; then | ||
| inherit git-r3 kde5-functions |
There was a problem hiding this comment.
Please don't use kde5-functions.eclass anymore:
This eclass must not be inherited directly by an ebuild.
There was a problem hiding this comment.
In general, what does this package add compared to installing applet-window-title via e.g. discover? It seems as if there is no build system to actually compile something.
There was a problem hiding this comment.
In general, what does this package add compared to installing applet-window-title via e.g. discover? It seems as if there is no build system to actually compile something.
I think nothing, but why then create an bin ebuild when you can download it and put into /opt?
I like the idea to install all from portage, but I understand that these are personal preferences.
There was a problem hiding this comment.
Please don't use kde5-functions.eclass anymore:
This eclass must not be inherited directly by an ebuild.
How manage src_{prepare,configure,compile} phases? Maybe, for example, with
src_configure() {
:
}
There was a problem hiding this comment.
In general, what does this package add compared to installing applet-window-title via e.g. discover? It seems as if there is no build system to actually compile something.
I think nothing, but why then create an bin ebuild when you can download it and put into /opt?
I like the idea to install all from portage, but I understand that these are personal preferences.
Well, I was citing from kde proj's packaging policy; and I disagree with your example, as it involves much more than simply using the upstream interface that provides a search and install button and auto-update facility as is the alternative here. ;) The package will always be slower to update than upstream, so we ask ourselves 'what advantage does the package give us'.
If you tell me that these two applets are typically used together, such that you even add a reference in pkg_postinst to that effect, then it would be awkward to provide only one as system package, I would agree with adding both to tree.
fedeliallalinea
force-pushed
the
plasma-applet-window-{buttons,title}
branch
from
bb105a7
to
7c7c1d6
Compare
| KFMIN=5.38.0 | ||
| QTMIN=5.9.0 | ||
| PLASMA_MINIMAL=5.12.0 |
There was a problem hiding this comment.
You can do that; But please note that KDE Frameworks 5.37 was dropped more than two years ago, and Qt 5.7 was gone soon afterwards (5.8 never packaged), and Plasma 5.11 as well. So you are quite safe from a packaging standpoint, not least because ecm.eclass already sets KFMIN=5.64.0 anyway. Unlike gnome proj we are not overzealous with minimum versions. ;)
Regarding PLASMA_MINIMAL: a variable used only once should rather not be declared at all.
| insinto /usr/share/plasma/plasmoids/org.kde.windowtitle | ||
| doins metadata.desktop |
There was a problem hiding this comment.
but domenu or newmenu insert in /usr/share/applications. All metadata.desktop are installed in plugin directory (see for example latte-dock)
| SLOT="0" | ||
| IUSE="" | ||
|
|
||
| DEPEND=" |
There was a problem hiding this comment.
If nothing is being built, do we need a DEPEND at all?
Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com> Bug: https://bugs.gentoo.org/703298
Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com> Bug: https://bugs.gentoo.org/703298
fedeliallalinea
force-pushed
the
plasma-applet-window-{buttons,title}
branch
from
7c7c1d6
to
e0bedcf
Compare
No description provided.