app-admin/syslog-ng: bump to 3.25.1 (with tests now ;)) #14051

hydrapolic · 2019-12-19T15:20:08Z

--- syslog-ng-3.24.1.ebuild     2019-12-18 12:08:50.520675041 +0100
+++ syslog-ng-3.25.1.ebuild     2019-12-19 16:05:56.806475404 +0100
@@ -3,7 +3,7 @@
 
 EAPI=7
 
-PYTHON_COMPAT=( python2_7 python3_{5,6,7,8} )
+PYTHON_COMPAT=( python3_{6,7,8} )
 inherit autotools python-single-r1 systemd
 
 MY_PV_MM=$(ver_cut 1-2)
@@ -14,10 +14,9 @@
 LICENSE="GPL-2+ LGPL-2.1+"
 SLOT="0"
 KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~riscv ~s390 ~sh ~sparc ~x86"
-IUSE="amqp caps dbi geoip2 http ipv6 json kafka libressl mongodb pacct python redis smtp snmp spoof-source systemd tcpd"
+IUSE="amqp caps dbi geoip2 http ipv6 json kafka libressl mongodb pacct python redis smtp snmp test spoof-source systemd tcpd"
 REQUIRED_USE="python? ( ${PYTHON_REQUIRED_USE} )"
-# unit tests require https://github.com/Snaipe/Criterion with additional deps
-RESTRICT="test"
+RESTRICT="!test? ( test )"
 
 RDEPEND="
        >=dev-libs/glib-2.10.1:2
@@ -41,7 +40,8 @@
        tcpd? ( >=sys-apps/tcp-wrappers-7.6 )
        !libressl? ( dev-libs/openssl:0= )
        libressl? ( dev-libs/libressl:0= )"
-DEPEND="${RDEPEND}"
+DEPEND="${RDEPEND}
+       test? ( dev-libs/criterion )"
 BDEPEND="
        sys-devel/flex
        virtual/pkgconfig"

Thanks

Needed for app-admin/syslog-ng tests Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>

Closes: https://bugs.gentoo.org/686276 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>

Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>

gentoo-bot · 2019-12-19T15:24:15Z

Pull Request assignment

Submitter: @hydrapolic
Areas affected: ebuilds, profiles
Packages affected: app-admin/syslog-ng, dev-libs/criterion

app-admin/syslog-ng: @hydrapolic, @gentoo/proxy-maint
dev-libs/criterion: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 686276

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2019-12-19T16:39:48Z

Pull request CI report

Report generated at: 2019-12-19 16:39 UTC
Newest commit scanned: 03bcbee
Status: ✅ good

juippis

Had to restrict tests on criterion because they failed. Gonna file a bug about it, you should fix it before making a KEYWORDING request because arch testers will stop there :)

 * Messages for package dev-libs/criterion-2.3.3:

 * QA Notice: make jobserver unavailable:
 *
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	gmake[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.

Thanks!

hydrapolic · 2019-12-20T06:44:49Z

Thanks @juippis.

Please open a bug for it as tests for criterion/syslog-ng passed on my ~amd64 machine.

That jobserver stuff is probably something to be fixed in the upstream Makefile :-/

hydrapolic added 3 commits December 19, 2019 16:05

dev-libs/criterion: add new package

ea55deb

Needed for app-admin/syslog-ng tests Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>

app-admin/syslog-ng: bump to 3.25.1

9a11a5d

Closes: https://bugs.gentoo.org/686276 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>

profiles/*/package.use.mask: mask app-admin/syslog-ng[test] on !amd64

03bcbee

Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>

juippis approved these changes Dec 20, 2019

View reviewed changes

gentoo-bot closed this in faf8a79 Dec 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app-admin/syslog-ng: bump to 3.25.1 (with tests now ;)) #14051

app-admin/syslog-ng: bump to 3.25.1 (with tests now ;)) #14051

hydrapolic commented Dec 19, 2019 •

edited

gentoo-bot commented Dec 19, 2019

gentoo-repo-qa-bot commented Dec 19, 2019

juippis left a comment

hydrapolic commented Dec 20, 2019

app-admin/syslog-ng: bump to 3.25.1 (with tests now ;)) #14051

app-admin/syslog-ng: bump to 3.25.1 (with tests now ;)) #14051

Conversation

hydrapolic commented Dec 19, 2019 • edited

gentoo-bot commented Dec 19, 2019

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Dec 19, 2019

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

hydrapolic commented Dec 20, 2019

hydrapolic commented Dec 19, 2019 •

edited