dev-util/jenkins-bin: GLEP 81 migration via bump #14121
Conversation
Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
Pull Request assignmentSubmitter: @Whissi acct-group/jenkins: @gentoo/proxy-maint (new package) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
| IUSE="" | ||
|
|
||
| COMMON_DEPS="acct-user/jenkins | ||
| acct-group/jenkins" |
There was a problem hiding this comment.
Sure, will fix that on merge.
|
|
||
| DESCRIPTION="Jenkins program user" | ||
| ACCT_USER_ID=473 | ||
| ACCT_USER_HOME=/var/lib/jenkins |
There was a problem hiding this comment.
@mjo suggested using the default home to avoid fighting for the home directory by various packages.
There was a problem hiding this comment.
Sorry, I don't understand. Which default home should be used instead? Package used
JENKINS_DIR=/var/lib/jenkins
pkg_setup() {
enewgroup jenkins
enewuser jenkins -1 -1 ${JENKINS_DIR} jenkins
}before and new acct-user/jenkins is mirroring this behavior. Not?
There was a problem hiding this comment.
It means that the acct-user/group package will only define the uid/gid, but the home directory will be specified in the dev-util/jenkins package itself as before.
| RESTRICT="mirror" | ||
| SLOT="lts" | ||
| KEYWORDS="~amd64 ~x86 ~amd64-linux" | ||
| IUSE="" |
There was a problem hiding this comment.
please clean up this mess too:
DESCRIPTION="Extensible continuous integration server"
HOMEPAGE="https://jenkins.io/"
SRC_URI="http://mirrors.jenkins-ci.org/war-stable/${PV}/${PN/-bin/}.war -> ${P}.war"
LICENSE="MIT"
SLOT="lts"
KEYWORDS="~amd64 ~x86 ~amd64-linux"
RESTRICT="mirror"
(drop empty IUSE)
|
Closed via 031848a |
When reviewing, please pay special attention to
I.e. I dropped $JENKINS_DIR because $JENKINS_DIR is HOME of acct-user/jenkins and acct-* stuff should take care of correct permissions.
Complete diff: