support webp gnome system-wide when is requested #14131
Conversation
Pull Request assignmentSubmitter: @okias x11-libs/gdk-pixbuf: @gentoo/gnome Linked bugsBugs linked: 703864, 703866, 693062 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
recreate merge request with x11-libs/gdk-pixbuf-loader-webp 0.0.1 (freshly released) |
| # Copyright 1999-2019 Gentoo Authors | ||
| # Distributed under the terms of the GNU General Public License v2 | ||
|
|
||
| EAPI=6 |
There was a problem hiding this comment.
no EAPI-7 love? this is in conflict with your git summary.
|
|
||
| LICENSE="LGPL-2+" | ||
| SLOT="0" | ||
| KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris" |
There was a problem hiding this comment.
where are all these keywords coming from? who tested those?
There was a problem hiding this comment.
from original package
There was a problem hiding this comment.
I don't see that:
Keywords for x11-libs/gdk-pixbuf-loader-webp:
| | u |
| a a p s a r | n |
| m r i p h m s p l i m | e u s | r
| d a m a p c x p 6 3 a p s i | a s l | e
| 6 r 6 6 p 6 8 p 8 9 s r h c p | p e o | p
| 4 m 4 4 c 4 6 a k 0 h c a v s | i d t | o
---------------+-------------------------------+-------+-------
20160328234507 | o o o o o o o o o o o o o o o | 6 o 0 | gentoo
| PATCHES=( "${FILESDIR}/web-pixbuf-loader_gentoo.patch" ) | ||
|
|
||
| DEPEND=" | ||
| >=media-libs/libwebp-0.4.3[${MULTILIB_USEDEP}] |
There was a problem hiding this comment.
looks like a slot operator candidate.
| KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris" | ||
|
|
||
| S="${WORKDIR}/${MY_PN}-${COMMIT}" | ||
| PATCHES=( "${FILESDIR}/web-pixbuf-loader_gentoo.patch" ) |
There was a problem hiding this comment.
weird to find PATCHES above dependencies.
| @@ -0,0 +1,54 @@ | |||
| # Copyright 1999-2019 Gentoo Authors | |||
There was a problem hiding this comment.
Invalid copyright, don't you use repoman?
There was a problem hiding this comment.
I made it (and also pushed and created MR) in 2019...
There was a problem hiding this comment.
How should I understand this then?
recreate merge request with x11-libs/gdk-pixbuf-loader-webp 0.0.1 (freshly released)
should this be closed in favor of a different PR?
|
if you find time to merge it, I'll rebase & fix it. |
|
don't you have that backwards? |
|
@a17r Not really, since it was rotting here (and in two bugzilla entries) for 3 months until you looked at it... I willing to make it in acceptable state, but only if there is chance to get it merged (to have benefits for users wanting use webp inside gnome or other GTK apps). |
|
I'm spending my free time here as well for a package I will likely never use, please understand that @gentoo/gnome must ack before I am able to merge. |
| !<gnome-base/librsvg-2.31.0 | ||
| !<x11-libs/gtk+-2.21.3:2 | ||
| !<x11-libs/gtk+-2.90.4:3 | ||
| webp? ( x11-libs/gdk-pixbuf-loader-webp:0=[${MULTILIB_USEDEP}] ) |
There was a problem hiding this comment.
IIRC QA team was fighting against optional runtime dependencies. Have things changed? Also shouldn't it be PDEPEND to prevent circular dependency?
There was a problem hiding this comment.
And slot-operator is not needed here.
|
Thanks :) |
it's |
Without looking into this PR much, this error is because eutils.eclass isn't inherited. |
|
ready for merge :) EAPI must be 6, since it does use gnome2_gdk_pixbuf_update which is broken in EAPI 7. |
|
Ready to review. |
|
|
||
| LICENSE="LGPL-2+" | ||
| SLOT="0" | ||
| KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~s390 ~sparc ~x86 ~amd64-linux ~x86-linux" |
There was a problem hiding this comment.
did you test all those arches? again, the current ebuild has none at all.
Keywords for x11-libs/gdk-pixbuf-loader-webp:
| | u |
| a a p s a r | n |
| m r i p h m s p l i m | e u s | r
| d a m a p c x p 6 3 a p s i | a s l | e
| 6 r 6 6 p 6 8 p 8 9 r h c p | p e o | p
| 4 m 4 4 c 4 6 a k 0 c a v s | i d t | o
---------------+-----------------------------+-------+-------
20160328234507 | o o o o o o o o o o o o o o | 6 o 0 | gentoo
There was a problem hiding this comment.
Fixed in v3. Added intersection between libwebp & gdk-pixbuf . Since it's just glue code.
I cannot test all arches, but this could be valid point to assume it will work on these arches, right?
Is it ok with you?
- use correct upstream name - move from x11-libs to gui-libs - migrate to meson Closes: https://bugs.gentoo.org/693062 Closes: https://bugs.gentoo.org/703864 v2: - EAPI=6 must be preserved due to gnome2_gdk_pixbuf_update incompatible with EAPI=7 v3: - matched keyword with libwebp U gdk-pixbuf-loader Signed-off-by: David Heidelberg <david@ixit.cz>
Since webp is widely used and we have available gdk-pixbuf wrapper, let's use it. v2: - drop sh architecture - update webp package name v3: - fix DEPEND (thanks @a17r ) - update homepage Closes: https://bugs.gentoo.org/703866 Signed-off-by: David Heidelberg <david@ixit.cz>
Pull request CI reportReport generated at: 2020-04-17 16:09 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Pushed into ::guru overlay for this moment. |
|
@gentoo/gnome does not maintain x11-libs/gdk-pixbuf-loader-webp, gdk-pixbuf shouldn't be changed like that, at least not so fast. |
This problem and other problems in |
|
@Arfrever thank you, updated in ::guru |
Links to open bugs in Closes: inside commits