flag-o-matic.eclass: a complete rewrite of get-flag() #1425
Conversation
|
@rindeal, hi. you know the drill by now: has this change been reviewed on the gentoo-dev ml? |
|
Hi @monsieurp, https://devmanual.gentoo.org/eclass-writing/ states that such workflow is necessary for major changes, API changes and new eclasses. None of those conditions apply here. |
|
sure but they ought to get reviewed nonetheless by someone from the toolchain team. @blueness @vapier @dirtyepic |
|
also I see bugfix in your commit message. Could you please provide a bug number? thanks! |
monsieurp
added
the
assigned
I'm not aware of any bug in bugzilla covering these bugs. |
|
@rindeal, it is also necessary for widely-used eclasses. Please |
rindeal
force-pushed
the
eclass/flag-o-matic/get-flag
branch
3 times, most recently
from
e486956
to
75cae1b
Compare
|
😞 The QA check for this pull request has found the following issues: Issues persisted from underlying repository state: |
rindeal
force-pushed
the
eclass/flag-o-matic/get-flag
branch
from
75cae1b
to
4dbbb3f
Compare
| } | ||
|
|
||
| fom-tbegin() { | ||
| clear-env |
There was a problem hiding this comment.
Couldn't you just clear-env once and limit the scope of CFLAGS= being set for calls?
There was a problem hiding this comment.
(like `CFLAGS='-foo' fom-run ...)
There was a problem hiding this comment.
I had this idea as well, unfortunately after I wrote all of it and haven't considered it to be worth the effort to change it.
rindeal
force-pushed
the
eclass/flag-o-matic/get-flag
branch
from
4dbbb3f
to
5727b5a
Compare
|
I've updated the following:
All in all, the code is now greater than ever. |
rindeal
changed the title
|
@mgorny is this PR ready for prime time? |
|
Was the final version posted for ml review? |
rindeal
force-pushed
the
eclass/flag-o-matic/get-flag
branch
from
5727b5a
to
4eadc15
Compare
Pull request CI reportReport generated at: 2024-03-18 03:24 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
- fix case: - `CFLAGS='-O1 -O2'` - `get-flag '-O*'` - before `-O1` - now `-O2` - fix case: - `CFLAGS='-W1,-O1'` - `get-flag '-O*'` - before `-W1,O1` - now return 1 `get-flag march` == "i686" syntax still works. Signed-off-by: rindeal <dev.rindeal@gmail.com>
Signed-off-by: rindeal <dev.rindeal@gmail.com>
rindeal
force-pushed
the
eclass/flag-o-matic/get-flag
branch
from
4eadc15
to
eb168fc
Compare
Pull request CI reportReport generated at: 2024-03-18 03:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
CFLAGS='-O1 -O2'get-flag '-O*'-O1-O2CFLAGS='-W1,-O1'get-flag '-O*'-W1,O1get-flag march== "i686" syntax still works.