Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(proxy-maint) net-dns/coredns: bump v1.6.9, drop old #14325

Closed
wants to merge 2 commits into from
Closed

(proxy-maint) net-dns/coredns: bump v1.6.9, drop old #14325

wants to merge 2 commits into from

Conversation

code-of-kpp
Copy link
Contributor

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @podshumok
Areas affected: ebuilds
Packages affected: net-dns/coredns

net-dns/coredns: kpp+gentoo[at]qrator.net, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 13, 2020
@code-of-kpp code-of-kpp changed the title (proxy-maint) net-dns/coredns: bump v1.6.6, drop old (proxy-maint) net-dns/coredns: bump v1.6.9, drop old Apr 24, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-24 10:29 UTC
Newest commit scanned: 27ba31b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5c27a77/output.html

code-of-kpp added a commit to code-of-kpp/gentoo that referenced this pull request Apr 24, 2020
@code-of-kpp
Bump coredns-1.6.9, enable tests, provide example config, remove old
48e9b9b 
Signed-off-by: Konstantin Podshumok <kpp.live+signed@gmail.com>
Closes: gentoo#14325
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-24 19:25 UTC
Newest commit scanned: 48e9b9b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9503b28/output.html

juippis
juippis reviewed Apr 28, 2020
View reviewed changes
net-dns/coredns/coredns-1.6.9.ebuild Outdated

LICENSE="Apache-2.0 MIT BSD ISC MPL-2.0 BSD-2"
SLOT="0"
IUSE=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

net-dns/coredns/coredns-1.6.9.ebuild Outdated

src_install() {
dobin ${PN}
dodoc README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

einstalldocs, just so it may catch something else useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

net-dns/coredns/coredns-1.6.9.ebuild Outdated
for suite in request core coremain plugin; do
pushd "${suite}" || die "no tests in ${S}/${suite}"
go test -race ./... || die "tests for ${S}/${suite} failed"
popd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| die

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

net-dns/coredns/coredns-1.6.9.ebuild Outdated
# mod files don't bring anything useful for reader of that ebuild
# but they are required by go modules
# SRC_URI will be defined after them
EGO_SUM+=(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this list and the SRC_URI part above among with the other list? Never seen any ebuild split like this so it feels weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

net-dns/coredns/files/coredns.initd
Comment on lines +22 to +30
if [[ -n "${COREDNS_HEALTHCHECK_URI}" ]]; then
healthcheck_delay=20
healthcheck_timer=30

healthcheck() {
command -v wget || return 0
wget -Oq- "${COREDNS_HEALTHCHECK_URI}"
}
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really make a difference? Wouldn't you always want it to be 127.0.0.1:8092/health?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not enabled by default by the upstream, port can also be different, as well as bind address (for example, I use 127.1.1.1)

juippis
juippis reviewed Apr 28, 2020
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and also split adding an ebuild and removing an ebuild to separate commits. So this should have 2 commits instead of one.

@code-of-kpp code-of-kpp changed the title (proxy-maint) net-dns/coredns: bump v1.6.9, drop old WIP (proxy-maint) net-dns/coredns: bump v1.6.9, drop old Apr 28, 2020
@code-of-kpp
Bump coredns-1.6.9, enable tests, provide example config
aa96647 
Closes: gentoo#14325
Signed-off-by: Konstantin Podshumok <kpp.live+signed@gmail.com>
@code-of-kpp
net-dns/coredns - remove old
e0d9bff 
Signed-off-by: Konstantin Podshumok <kpp.live+signed@gmail.com>
@code-of-kpp
Copy link
Contributor Author

Oh and also split adding an ebuild and removing an ebuild to separate commits. So this should have 2 commits instead of one.

done

@code-of-kpp code-of-kpp changed the title WIP (proxy-maint) net-dns/coredns: bump v1.6.9, drop old (proxy-maint) net-dns/coredns: bump v1.6.9, drop old Apr 28, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-28 19:46 UTC
Newest commit scanned: e0d9bff
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3740a01/output.html

gentoo-bot pushed a commit that referenced this pull request Apr 29, 2020
@code-of-kpp @juippis
net-dns/coredns: remove old
1b91d35 
Signed-off-by: Konstantin Podshumok <kpp.live+signed@gmail.com>
Closes: #14325
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@code-of-kpp @gentoo-bot @gentoo-repo-qa-bot @juippis