media-gfx/gimp: update 9999.ebuild dependencies #14418
Conversation
Pull Request assignmentSubmitter: @band-a-prend media-gfx/gimp: @band-a-prend, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
media-libs/gegl/gegl-0.4.20.ebuild
Outdated
| # Distributed under the terms of the GNU General Public License v2 | ||
|
|
||
| EAPI=7 | ||
| PYTHON_COMPAT=( python{2_7,3_{6,7}} ) |
There was a problem hiding this comment.
Please keep an empty line after EAPI. It is fine to keep the pre-inherit variables in the same block though.
What about python3_8?
| IUSE="cpu_flags_x86_avx2 cpu_flags_x86_sse cpu_flags_x86_sse2 cpu_flags_x86_sse3 cpu_flags_x86_sse4_1 cpu_flags_x86_mmx cpu_flags_x86_f16c introspection lcms" | ||
| IUSE="introspection lcms cpu_flags_x86_avx2 cpu_flags_x86_f16c cpu_flags_x86_mmx cpu_flags_x86_sse cpu_flags_x86_sse2 cpu_flags_x86_sse3 cpu_flags_x86_sse4_1" |
There was a problem hiding this comment.
(+ all other changes in 0.1.74): It is okay in ~arch, but please try to keep unnecessary (=zero-sum) changes in release ebuilds at a minimum.
There was a problem hiding this comment.
Sorry. I added myself here for media-libs/babl as maintainer and because @Polynomial-C already bump version before it I just made simple changes before next new release.
virtual/pkgconfig is moved now to BDEPEND in both babl-{0.1.74,9999}.ebuild
media-libs/babl/babl-9999.ebuild
Outdated
| @@ -19,7 +19,7 @@ HOMEPAGE="http://www.gegl.org/babl/" | |||
|
|
|||
| LICENSE="LGPL-3" | |||
| SLOT="0" | |||
| IUSE="cpu_flags_x86_avx2 cpu_flags_x86_sse cpu_flags_x86_sse2 cpu_flags_x86_sse3 cpu_flags_x86_sse4_1 cpu_flags_x86_mmx cpu_flags_x86_f16c introspection lcms" | |||
| IUSE="introspection lcms cpu_flags_x86_avx2 cpu_flags_x86_f16c cpu_flags_x86_mmx cpu_flags_x86_sse cpu_flags_x86_sse2 cpu_flags_x86_sse3 cpu_flags_x86_sse4_1" | |||
|
|
|||
| RDEPEND="lcms? ( media-libs/lcms:2 )" | |||
| DEPEND="${RDEPEND} | |||
There was a problem hiding this comment.
virtual/pkgconfig should be in BDEPEND.
media-libs/gegl/gegl-0.4.20.ebuild
Outdated
| " | ||
|
|
||
| DEPEND=" | ||
| ${RDEPEND} | ||
| " | ||
|
|
There was a problem hiding this comment.
It is fine to do this in one line if the only content of DEPEND is RDEPEND. Imo it is also unnecessary to separate the blocks with empty lines when you already spend a newline for the terminating quote, but that is really minor nitpicking.
| @@ -1,4 +1,4 @@ | |||
| # Copyright 1999-2019 Gentoo Authors | |||
| # Copyright 1999-2020 Gentoo Authors | |||
| # Distributed under the terms of the GNU General Public License v2 | |||
|
|
|||
| EAPI=6 | |||
Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
band-a-prend
force-pushed
the
gimp-live
branch
from
147528a
to
5613a56
Compare
This pull request