Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-libs/nodejs: add USE=+system-ssl #14460

Closed
wants to merge 1 commit into from
Closed

Conversation

steils
Copy link
Member

@steils steils commented Jan 26, 2020

Bug: https://bugs.gentoo.org/613344
Package-Manager: Portage-2.3.85, Repoman-2.3.20
Signed-off-by: Stefan Strogin steils@gentoo.org

Bug: https://bugs.gentoo.org/613344
Package-Manager: Portage-2.3.85, Repoman-2.3.20
Signed-off-by: Stefan Strogin <steils@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @steils
Areas affected: ebuilds
Packages affected: net-libs/nodejs

net-libs/nodejs: @jer-gentoo

Linked bugs

Bugs linked: 613344


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 26, 2020
Copy link
Contributor

@jer-gentoo jer-gentoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentoo doesn't normally allow using bundled code when compatible shared libraries are available in another package. dev-libs/openssl as provider of shared libraries works fine for net-libs/nodejs, so currently you get either --shared-openssl (that's the system openssl) or you get --without-ssl.

Since you omitted a rationale for these changes I cannot even figure out why you would want to add USE=system-ssl. What problem are you trying to fix?

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-01-26 20:08 UTC
Newest commit scanned: 870bccf
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-admin/consul-template
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-admin/fluentd
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-admin/puppet
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-admin/puppet-agent
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-admin/puppetdb
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-admin/puppetserver
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-crypt/mcrypt
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-emulation/virtualbox-additions
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-emulation/virtualbox-guest-additions
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-emulation/virtualbox-modules
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-forensics/sleuthkit
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-office/libreoffice-bin-debug
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-text/jabref-bin
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#app-text/wscr
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-db/mysql
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-db/postgresql
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-java/gin
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-java/gwt
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-java/netbeans-platform
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-lang/R
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-ml/lablgtk
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-python/doit
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-python/parver
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-python/pygame
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-ros/roslaunch
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-util/cookiecutter
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-util/google-perftools
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#dev-vcs/gitsh
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#games-strategy/freeciv
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#games-util/pogo-manager-bin
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#gnustep-apps/sogo
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#mail-filter/spamassassin
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#media-gfx/iscan
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#media-sound/podcatcher
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#media-tv/gentoo-vdr-scripts
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#media-video/ushare
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/fail2ban
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/metasploit
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/nagios-check_multiple
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/nagios-core
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/ntopng
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/snort
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/tcpdump
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/vnstat
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/wireshark
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-analyzer/zabbix
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-dns/bind
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-dns/dnsdist
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-dns/unbound
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-libs/nodejs
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-misc/apt-cacher-ng
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-misc/dhcp
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-misc/gerbera
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-misc/icaclient
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-misc/kea
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-misc/pulseaudio-dlna
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-misc/youtube-dl
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-p2p/bisq
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-p2p/fms
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-print/cups
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-proxy/haproxy
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-proxy/squidguard
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-vpn/strongswan
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#net-wireless/kismet
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-chemistry/nmrdepaker
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-chemistry/pymol
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-libs/nlopt
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-libs/parmetis
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-libs/scikits_learn
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-libs/tensorflow
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-libs/tensorflow-estimator
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-mathematics/geogebra
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-mathematics/normaliz
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-visualization/gwyddion
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-visualization/pythonprop
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sci-visualization/veusz
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-apps/shadow
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-auth/nss-pam-ldapd
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-cluster/cinder
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-cluster/crmsh
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-cluster/glusterfs
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-cluster/kube-apiserver
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-cluster/kube-controller-manager
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-cluster/kube-scheduler
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-cluster/neutron
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#sys-fs/tmsu
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#virtual/cargo
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#virtual/jdk
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#virtual/jre
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#www-apps/cgit
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#www-apps/grafana-bin
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#www-apps/netbox
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#www-apps/postfixadmin
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#www-misc/shellinabox
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#www-servers/nginx
https://qa-reports.gentoo.org/output/gentoo-ci/ec30e0c/output.html#x11-misc/dzen

@steils
Copy link
Member Author

steils commented Jan 27, 2020

Since you omitted a rationale for these changes I cannot even figure out why you would want to add USE=system-ssl. What problem are you trying to fix?

Hi Jeroen. I have linked a bug about that. Unfortunately nodejs fails to build with LibreSSL as a shared ssl library. This package is too hard for me to patch, and the upstream doesn't support LibreSSL. Fortunately nodejs can be built with bundled OpenSSL. A similar solution was used in dev-util/electron: #11494

@steils
Copy link
Member Author

steils commented Feb 2, 2020

@jer-gentoo Do you have any other questions/objections/suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants