New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-libs/nodejs: add USE=+system-ssl #14460
Conversation
Bug: https://bugs.gentoo.org/613344 Package-Manager: Portage-2.3.85, Repoman-2.3.20 Signed-off-by: Stefan Strogin <steils@gentoo.org>
Pull Request assignmentSubmitter: @steils net-libs/nodejs: @jer-gentoo Linked bugsBugs linked: 613344 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentoo doesn't normally allow using bundled code when compatible shared libraries are available in another package. dev-libs/openssl as provider of shared libraries works fine for net-libs/nodejs, so currently you get either --shared-openssl (that's the system openssl) or you get --without-ssl.
Since you omitted a rationale for these changes I cannot even figure out why you would want to add USE=system-ssl. What problem are you trying to fix?
Hi Jeroen. I have linked a bug about that. Unfortunately nodejs fails to build with LibreSSL as a shared ssl library. This package is too hard for me to patch, and the upstream doesn't support LibreSSL. Fortunately nodejs can be built with bundled OpenSSL. A similar solution was used in |
@jer-gentoo Do you have any other questions/objections/suggestions? |
Bug: https://bugs.gentoo.org/613344
Package-Manager: Portage-2.3.85, Repoman-2.3.20
Signed-off-by: Stefan Strogin steils@gentoo.org