New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-db/sqlcl-bin: version bump to 19.4.0.354.0937 #14476
dev-db/sqlcl-bin: version bump to 19.4.0.354.0937 #14476
Conversation
Pull Request assignmentSubmitter: @fedeliallalinea dev-db/sqlcl-bin: @fedeliallalinea, @mudler, @gentoo/proxy-maint Linked bugsBugs linked: 706648 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
SLOT="0" | ||
KEYWORDS="~amd64 ~x86" | ||
|
||
DEPEND="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty variable can be dropped.
RDEPEND="virtual/jre:1.8 | ||
dev-java/java-config:2 | ||
dev-db/oracle-instantclient" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort in alphabetical order (ie just reverse the list). Sorry for these minor nitpicks after it's stood for so long, but let's make it look good! Can't really test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems, I understand and share this point of view
6f3effd
to
fa1eeef
Compare
Pull request CI reportReport generated at: 2020-02-19 14:29 UTC New issues caused by PR: Issues already there before the PR (double-check them): |
Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com> Bug: https://bugs.gentoo.org/706648
Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com>
fa1eeef
to
1ce38ad
Compare
No description provided.