net-dialup/freeradius: Bump v.3.0.20 #14488
Conversation
Pull Request assignmentSubmitter: @geaaru net-dialup/freeradius: @geaaru, @gentoo/proxy-maint Linked bugsBugs linked: 696458 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
|
|
||
| # NOTE: Temporary freeradius doesn't support linking with mariadb client | ||
| # libs also if code is compliant, will be available in the next release. | ||
| # (http://lists.freeradius.org/pipermail/freeradius-devel/2018-October/013228.html)a |
There was a problem hiding this comment.
Can this NOTE be fixed now?
|
|
||
| # TODO: rlm_mschap works with both samba library or without. I need to avoid | ||
| # linking of samba library if -samba is used. | ||
| RDEPEND="acct-group/radius |
There was a problem hiding this comment.
Can we please sort all the use? below? It's a real mess currently.
There was a problem hiding this comment.
Do you speak of the use flags inside RDEPEND or in IUSE?
| "${FILESDIR}"/${P}-systemd-service.patch | ||
| # Fix rlm_python3 build | ||
| # Backport from rlm_python changes to rlm_python3 | ||
| "${FILESDIR}"/${P}-py3-fixes.patch |
There was a problem hiding this comment.
Patch doesn't apply.
Also, patch is enormous, 42kB. That's not acceptable. Fortunately, I think you can cut nearly 2/3 of it by removing the changes to the generated configure script.
There was a problem hiding this comment.
I'm not sure of this. I simply used the patches from upstream to avoid fork code from upstream. If we want drop py2.7 support this is the more simple way todo this. IMHO.
An alternative could be use git-r3 eclass and point to hash directly.
There was a problem hiding this comment.
Dropped configure section. I don't like this but I did.
There was a problem hiding this comment.
I don't understand why you don't like removing the diff to configure? The ebuild runs eautoreconf so the patched configure.ac is going to produce the patched configure, so... patching configure itself isn't necessary.
Am I misunderstanding something, or are you?
There was a problem hiding this comment.
Just because I prefer to follow upstream changes. But I dropped configure changes as you have indicated.
Let me know if it's all ok now.
geaaru
force-pushed
the
freeradius-3.0.20
branch
from
abaf3be
to
05e83f9
Compare
Package-Manager: Portage-2.3.69, Repoman-2.3.14 Closes: https://bugs.gentoo.org/696458 Signed-off-by: Daniele Rondina <geaaru@gmail.com>
geaaru
force-pushed
the
freeradius-3.0.20
branch
from
05e83f9
to
b7545c8
Compare
Bump v.3.0.20 with these new features: