net-vpn/protonvpn-cli: new package for protonvpn commandline tool #14513
Conversation
Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Amel Hodzic <ilmostro7@gmail.com>
Pull Request assignmentSubmitter: @ILMostro net-vpn/protonvpn-cli: @gentoo/proxy-maint (new package) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Amel Hodzic <ilmostro7@gmail.com> net-vpn/protonvpn-cli: reviewed changes * Correct license * Add missing deps * github page as additional homepage Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Amel Hodzic <ilmostro7@gmail.com>
Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Amel Hodzic <ilmostro7@gmail.com>
| KEYWORDS="~amd64" | ||
| SLOT="0" | ||
|
|
||
| RDEPEND="dev-python/setuptools[${PYTHON_USEDEP}] |
There was a problem hiding this comment.
You should to define this via eclass,
* DISTUTILS_USE_SETUPTOOLS value is probably incorrect
* value: DISTUTILS_USE_SETUPTOOLS=bdepend (default?)
* expected: DISTUTILS_USE_SETUPTOOLS=rdepend
Check the devmanual page for how to use DISTUTILS_USE_SETUPTOOLS
Could you also squash your commits into a single one? I think the merge commit in the middle somehow messes this up, it doesn't apply cleanly at all.
There was a problem hiding this comment.
I have opened a new PR with the changes applied at #14725
Package-Manager: Portage-2.3.84, Repoman-2.3.20
Signed-off-by: Amel Hodzic ilmostro7@gmail.com