-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-libs/pigpio: new version 74 #14543
Conversation
Pull Request assignmentSubmitter: @github-k8n dev-libs/pigpio: @github-k8n, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Add small change to use package provided systemd unit file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor styling annoyances.
dev-libs/pigpio/pigpio-74.ebuild
Outdated
inherit distutils-r1 systemd toolchain-funcs | ||
|
||
DESCRIPTION="A library for the Raspberry which allows control of the GPIOs" | ||
HOMEPAGE="http://abyz.me.uk/rpi/pigpio/index.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the Github page here as a secondary homepage.
dev-libs/pigpio/pigpio-74.ebuild
Outdated
src_prepare() { | ||
eapply "${FILESDIR}/${PN}-70-makefile.patch" | ||
eapply_user | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just use a global PATCHES=( ... )
array here for the patch file, then you can remove these 4 lines.
dev-libs/pigpio/pigpio-74.ebuild
Outdated
einstalldocs | ||
newinitd "${FILESDIR}"/pigpiod.initd pigpiod | ||
newconfd "${FILESDIR}"/pigpiod.confd pigpiod | ||
systemd_newunit "${WORKDIR}"/"${P}"/util/pigpiod.service pigpiod.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"${WORKDIR}"/"${P}"
should be the current working directory, so just calling systemd_newunit util/pigpiod.service pigpiod.service
should work and be a bit more elegant. Or ${S}
.
new upstream version, adjust download URL, use package provided systemd unit file, minor tweaks Signed-off-by: Daniel Kenzelmann <gentoo@k8n.de>
All updated and rebased. Thanks for the tips! |
new upstream version, adjust download URL
Signed-off-by: Daniel Kenzelmann gentoo@k8n.de