-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirt + qemu live ebuild fixes #14550
Conversation
Pull Request assignmentSubmitter: @zippy2 app-emulation/libvirt: @tamiko, @gentoo/virtualization Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
https://bugs.gentoo.org/708002 needs to be dealt with as well. |
There are two changes necessary for our live ebuild. The first one consists of rebasing qemu-2.5.0-cflags.patch because the configure file it's patching has diverged too much. The second change removes qemu-2.5.0-sysmacros.patch from the list of patches for its needlessness. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
The upstream has removed PHYP driver support in v6.0.0-rc1~127. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
The live ebuild of libvirt applies fix-paths-for-apparmor patch which fixes paths in profiles so that the libexec path is honoured. However, in upstream I've made necessary changes so that the correct paths are generated into the profiles (upstream patches v6.0.0-270-gbb4ab7ac91 v6.0.0-269-g5c8bd31c88 v6.0.0-218-g8f204fb4da). Therefore, it is no longer necessary for the ebuild to apply the patch. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
In a20edcb the do-not-use-sysconf patch was rebased onto current upstream. However, the live ebuild was not updated and so it still tries to apply the old patch, which fails. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Strictly speaking, this is not needed. But the upstream version of the libvirt-guests.sh file has changed a bit so patch needs to do some offsetting when applying the patch. Avoid that by rebasing the patch onto current upstream. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
The upstream commit of v6.0.0-rc1~363 started to require rst2html5 and rst2man scripts for generating docs/manpages at compile time. These scripts are part of dev-python/docuitls package. Record this build time dependency in both live and 6.0.0 ebuilds. Bug: https://bugs.gentoo.org/708002 Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
a6749f8
to
bcf466a
Compare
Thanks for bringing this up. I've updated the pull request and the bug. |
Thanks a lot for helping out! Pushing your pull request to the repo as we speak. |
Upstreams of these project move fast. Rebase some patches we apply on the top master, drop some, drop some unused use flags, etc.