Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www-misc/monitorix: Update for GLEP 81 #14739

Closed
wants to merge 4 commits into from
Closed

www-misc/monitorix: Update for GLEP 81 #14739

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2020

No description provided.

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 22, 2020
@mgorny mgorny removed the assigned PR successfully assigned to the package maintainer(s). label Mar 5, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Dwosky
Areas affected: ebuilds
Packages affected: acct-group/monitorix, acct-user/monitorix, www-misc/monitorix

acct-group/monitorix: @gentoo/proxy-maint (new package)
acct-user/monitorix: @gentoo/proxy-maint (new package)
www-misc/monitorix: @Dwosky, @gentoo/proxy-maint

Linked bugs

Bugs linked: 694676

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. labels Mar 5, 2020
juippis
juippis reviewed Apr 30, 2020
View reviewed changes
acct-user/monitorix/monitorix-0.ebuild Outdated

DESCRIPTION="Monitorix system tool user"
ACCT_USER_ID=401
ACCT_USER_HOME=/var/lib/monitorix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?
http://michael.orlitzky.com/articles/gentoo_glep81_user_package_guidelines.xhtml#the-home-directory

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't saw that article when checking for GLEP 81. In fact it isn't really needed, so I've removed it.

acct-user/monitorix/metadata.xml Outdated
<email>proxy-maint@gentoo.org</email>
<name>Proxy Maintainers</name>
</maintainer>
</pkgmetadata>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github shows these errors in your files, I'm not really sure what they mean, but probably something with your editor. Could you check?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the missing newline at the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, yes, that much was obvious, but I don't remember how to fix these. I had the same error when I used emacs. So I'd say it's something in your editor's configuration.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was like that, I've checked both user and group file and should be corrected.

Dwosky added 4 commits May 1, 2020 21:13
@Dwosky
acct-group/monitorix: New group for monitorix
731b5ad 
Signed-off-by: Pedro Arizmendi <dwosky@pm.me>
Package-Manager: Portage-2.3.84, Repoman-2.3.20
@Dwosky
acct-user/monitorix: New user for monitorix
ac5637b 
Signed-off-by: Pedro Arizmendi <dwosky@pm.me>
Package-Manager: Portage-2.3.84, Repoman-2.3.20
@Dwosky
www-misc/monitorix: Remove execution bit from file
c8759ff 
Signed-off-by: Pedro Arizmendi <dwosky@pm.me>
Package-Manager: Portage-2.3.84, Repoman-2.3.20
@Dwosky
www-misc/monitorix: Update for GLEP 81
4478dfc 
Closes: https://bugs.gentoo.org/694676
Signed-off-by: Pedro Arizmendi <dwosky@pm.me>
Package-Manager: Portage-2.3.84, Repoman-2.3.20
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-01 23:02 UTC
Newest commit scanned: 4478dfc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/00ff425/output.html

@gentoo-bot gentoo-bot closed this in f4aae35 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
6 participants
@gentoo-bot @gentoo-repo-qa-bot @thesamesam @juippis @mgorny @Dwosky