dev-python/importlib_resources: Fix byte-compilation #14753
Conversation
Resolve QA warnings regarding Python byte-compilation. Closes: https://bugs.gentoo.org/703104 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Ralph Seichter <gentoo@seichter.de>
Pull Request assignmentSubmitter: @rseichter dev-python/importlib_resources: @rseichter, @gentoo/proxy-maint, @sbraz, @gentoo/python Linked bugsBugs linked: 703104 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
|
@rseichter I didn't notice this bug was still open, I might just drop Python 2 support from the package since it's going away eventually anyway. |
|
@sbraz Hopefully, some fine day we can all stop supporting Python 2. ;-) For now, my fix does the job, and I'd be glad if somebody just merged it. You could do that, I assume? |
| rm "${BUILD_DIR}/lib/importlib_resources/_py3.py" || die | ||
| fi | ||
| if use doc; then | ||
| sphinx-build ${PN}/docs docs/_build/html || die |
There was a problem hiding this comment.
Why do you build it repeatedly for every impl?
There was a problem hiding this comment.
Oops, that used to be in python_compile_all and apparently I moved it for no reason that I can remember. ;-) Thinking of it now, would using distutils_enable_sphinx not be a better choice anyway?
There was a problem hiding this comment.
It would but I don't think it existed when I made the ebuild. I'm going to fix this locally before I merge the PR.
There was a problem hiding this comment.
Thanks, I'll leave it to you then.
This reverts commit 4b3133e671b958fa2c915a4faf57812820124a7b upstream. See #14753 - possible corruption again, very similar symptoms to the nightmare that was #11900 and same area of code. We can safely revert it as it's an optimisation rather than a bugfix in itself. Keen Gentoo users may remember the following commits (in Gentoo): - 8e5626d - 9fb275f - 95c250a Bug: openzfs/zfs#14753 Bug: openzfs/zfs#11900 Signed-off-by: Sam James <sam@gentoo.org>
Resolve QA warnings regarding Python byte-compilation.