Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/libgeodecomp: Add 9999 ebuild #14855

Closed
wants to merge 6 commits into from

Conversation

shifty91
Copy link
Contributor

@shifty91 shifty91 commented Mar 7, 2020

The version v0.4.0 is six years old. Since then over 2000 commits introducing new features and fixes have been made. Therefore, it make sense to add an 9999 ebuild to use the current version.

The current libgeodecomp version needs a current libflatarray as well. While here, cleanup some minor issues and last open bugs in the libgeodecomp ebuilds.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Kurt Kanzenbach kurt@kmk-computers.de

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Mar 7, 2020
@shifty91 shifty91 changed the title sci-libs/libgeodecomp: Add 9999 ebuild sci-libs/libgeodecomp: Add 9999 ebuild [please reassign] Mar 8, 2020
@gentoo-bot gentoo-bot changed the title sci-libs/libgeodecomp: Add 9999 ebuild [please reassign] sci-libs/libgeodecomp: Add 9999 ebuild Mar 8, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @shifty91
Areas affected: ebuilds
Packages affected: dev-libs/libflatarray, sci-libs/libgeodecomp

dev-libs/libflatarray: @shifty91, @gentoo/proxy-maint
sci-libs/libgeodecomp: @shifty91, @gentoo/proxy-maint

Linked bugs

Bugs linked: 686294


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Mar 8, 2020
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to add -9999 to get the current version? There is an option to add a snapshot as well based on git commit. This way you can have KEYWORDS in it and use it like a regular package.

If you'd prefer that, check something like
https://packages.gentoo.org/packages/media-libs/rlottie
for hints how it's made.
https://devmanual.gentoo.org/ebuild-writing/file-format/index.html

@shifty91
Copy link
Contributor Author

Didn't know about the snapshot option. Seems like that's exactly what I need. I'll change it. Thanks!

This is needed as dependency for the current sci-libs/libgeodecomp version.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
The check for boost>=1.48 is nowadays always true.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Sort options and dependencies alphanumerically.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Add homepage to official source code repository.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
@shifty91 shifty91 force-pushed the libgeodecomp-9999 branch 2 times, most recently from bad6820 to 1d62ab4 Compare March 14, 2020 19:40
@shifty91
Copy link
Contributor Author

@juippis Moved to snaphot based on git commits.

Version v0.4.0 is quite old. Thus it makes sense to add the possibility to build
from the current source code.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
When hpx is installed libgeodecomp tries to use the boost libraries detected by
hpx. That doesn't work, because the wrong variables are referenced and hpx uses
fewer boost libraries than libgeodecomp.

So remove that and use the system boost libraries in all cases.

Closes: https://bugs.gentoo.org/686294
Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-03-15 15:48 UTC
Newest commit scanned: aabba64
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-admin/puppet
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-admin/rsyslog
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-admin/system-tools-backends
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-emulation/bochs
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-emulation/virtualbox-additions
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-emulation/virtualbox-guest-additions
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-emulation/virtualbox-modules
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-i18n/tomoe
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-office/libreoffice-l10n
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-shells/hstr
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#app-text/jo
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#dev-db/pgagent
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#dev-lang/rust
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#dev-libs/gjs
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#dev-python/genson
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#dev-python/schedule
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#dev-util/jenkins-bin
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#mail-client/claws-mail
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#mail-client/thunderbird
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#mail-mta/nullmailer
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#media-libs/cogl
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#media-libs/mlt
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#media-tv/kodi
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#media-video/unifi-video
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-analyzer/wireshark
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-analyzer/zabbix
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-dns/avahi
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-dns/bind
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-dns/unbound
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-im/mattermost-desktop-bin
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-misc/openssh
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-misc/rabbitmq-server
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-misc/youtube-dl
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-proxy/dante
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-proxy/haproxy
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-vpn/networkmanager-openvpn
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-wireless/kismet
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-wireless/tempestsdr
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#net-wireless/urh
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sci-libs/ceres-solver
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sci-libs/eccodes
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sci-libs/spqr
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sci-libs/suitesparse
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sci-libs/umfpack
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sys-apps/agedu
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sys-apps/coreutils
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sys-cluster/swift
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#sys-power/nut
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-apps/cgit
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-apps/jekyll
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-apps/netbox
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-apps/trac
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-client/firefox
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-client/seamonkey
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-servers/nginx
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-servers/tomcat
https://qa-reports.gentoo.org/output/gentoo-ci/9806f81/output.html#www-servers/tornado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants