sys-apps/bleachbit-3.2.0_p20200308: upgraded to python3 #14902
Conversation
Pull Request assignmentSubmitter: @lg188 sys-apps/bleachbit: @tietzc, @gentoo/proxy-maint Linked bugsBugs linked: 711962 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
|
||
| EAPI=7 | ||
|
|
||
| PYTHON_COMPAT=( python3_6 ) |
There was a problem hiding this comment.
Can you test if it works with 3.7 and 3.8 as well?
|
|
||
| PYTHON_COMPAT=( python3_6 ) | ||
| PYTHON_REQ_USE="sqlite(+)" | ||
| DISTUTILS_SINGLE_IMPL=1 |
There was a problem hiding this comment.
Remove this if above is applicable.
| $(python_gen_cond_dep ' | ||
| dev-python/chardet[${PYTHON_MULTI_USEDEP}] | ||
| dev-python/pygobject:3[${PYTHON_MULTI_USEDEP}] | ||
| dev-python/scandir[${PYTHON_MULTI_USEDEP}]') " |
There was a problem hiding this comment.
scandir has been included in Python 3.5+. You can most likely drop it.
| $(python_gen_cond_dep ' | ||
| dev-python/chardet[${PYTHON_MULTI_USEDEP}] | ||
| dev-python/pygobject:3[${PYTHON_MULTI_USEDEP}] | ||
| dev-python/scandir[${PYTHON_MULTI_USEDEP}]') " |
There was a problem hiding this comment.
Minor nit. Please make this consistent with BDEPEND, i.e. move quotation mark to next line.
There was a problem hiding this comment.
Upstream seems to have python tests enabled, could those be implemented in the ebuild? Allows checking compatibility of different python interpreters through testing really fast.
Also @tietzc's comments look solid.
Let us know if you have issues / confusion what exactly to do.
|
I implemented most of the feedback in the ebuild and it's almost ready. Though I did get stuck during testing and haven't touched it since. Testing the different python version and making sure the dependencies are installed is a bit more confusing than I thought. Also I have no idea how to add tests to ebuild so documentation of that is always welcome |
Bug: https://bugs.gentoo.org/711962 Signed-off-by: Lander Ghekiere <lander.ghekiere@gmail.com>
lg188
force-pushed
the
bleachbit-python3
branch
from
f592ecc
to
e630fad
Compare
|
Thanks for addressing my concerns. In terms of tests: https://dev.gentoo.org/~mgorny/python-guide/distutils.html and recent commits in the Gentoo repo. Maybe @juippis can help further. |
|
Unfortunately due to some school situations, I won't be able to add tests to this in the near future. |
Bug: https://bugs.gentoo.org/711962
Signed-off-by: Lander Ghekiere lander.ghekiere@gmail.com