Dev-python/spyder: replace patch with sed #15170
Conversation
trying to patch file with DOS EOL the patch got converted to UNIX EOL somehwere along the road and is not working Bug: https://bugs.gentoo.org/715148 Package-Manager: Portage-2.3.96, Repoman-2.3.22 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
Package-Manager: Portage-2.3.96, Repoman-2.3.22 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
Pull Request assignmentSubmitter: @AndrewAmmerlaan dev-python/spyder: Linked bugsBugs linked: 715148 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
|
Hi @AndrewAmmerlaan , |
That might work to. However, regardless of whether I use a patch or sed, I have to remove it in the next version bump anyway cause the next version is supposed to allow usage of newer parso versions anyway, thus making the whole patching/sed'ing obsolete anyway. So in this case I think there's no advantage to using a patch, and it would just be extra work. |
Package-Manager: Portage-2.3.96, Repoman-2.3.22 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net> Closes: gentoo#15170 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
The patch introduced in #15149 to fix bug https://bugs.gentoo.org/715148 patches a file with DOS End-Of-Line. Somewhere along the way the patch got converted to UNIX EOL and it's no longer working. So I'm using sed instead in this PR