Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games-simulation/simutrans: Version bump 0.122.0. #15314

Closed
wants to merge 2 commits into from

Conversation

tastytea
Copy link
Contributor

Also add a Desktop Entry and all the maintained paksets (scenario data) via
use-flags.

Closes: https://bugs.gentoo.org/668504
Signed-off-by: Ronny Gutbrod gentoo@tastytea.de


I've added the other paksets because the default one uses 64x64 pixel graphics,
which most users don't want since it looks not that great on modern monitors.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @tastytea
Areas affected: ebuilds
Packages affected: games-simulation/simutrans

games-simulation/simutrans: @gentoo/games

Linked bugs

Bugs linked: 668504


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 11, 2020

src_install() {
newbin build/default/sim ${PN}
insinto /usr/share/${PN}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be simplified with dodoc? It already installs into that directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to simutrans/*? That are datafiles that go into /usr/share/simutrans. I don't see what dodoc could do here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're right, sorry.

doins -r simutrans/*
dodoc documentation/*
insinto /usr/share/icons/hicolor/32x32/apps
doins simutrans.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doicon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course 🤦, fixed.

pak128-german? ( mirror://sourceforge/simutrans/${SIMUPAK_128_GERMAN} -> simutrans_${SIMUPAK_128_GERMAN} )
pak192-comic? (
mirror://sourceforge/simutrans/${SIMUPAK_192_COMIC} -> simutrans_${SIMUPAK_192_COMIC}
https://www.dropbox.com/s/3wwyrajrr2oqzo6/coalwagons.rar?dl=1 -> simutrans_coalwagonfix.rar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more official source for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most official source I could find (from: https://forum.simutrans.com/index.php/topic,17735.msg168977.html#msg168977). Their git repository starts over a year later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, no problem :)

@tastytea tastytea force-pushed the games-simulation/simutrans branch from 17edf6a to a165f4c Compare May 4, 2020 08:54
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-04 13:47 UTC
Newest commit scanned: a165f4c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ab45ffb/output.html

@Hawk777
Copy link
Contributor

Hawk777 commented Oct 20, 2020

I suspect this fixes https://bugs.gentoo.org/664634.

@mgorny
Copy link
Member

mgorny commented Oct 23, 2020

I'm sorry but it seems that games team is not really interested in this package. Would you like to take it via proxy-maint? If yes, please add yourself to metadata.xml and update this for the newest version.

@tastytea tastytea changed the title games-simulation/simutrans: Version bump 0.121.0. games-simulation/simutrans: Version bump 0.122.0. Oct 23, 2020
@tastytea
Copy link
Contributor Author

Updated ebuild to 122.0 and deleted 120.2.2, since it doesn't compile since 2018. Also added support for some optional dependencies.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-23 15:11 UTC
Newest commit scanned: ea234f6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/090284a455/output.html

games-simulation/simutrans/metadata.xml Outdated Show resolved Hide resolved
games-simulation/simutrans/metadata.xml Outdated Show resolved Hide resolved
games-simulation/simutrans/simutrans-0.122.0.ebuild Outdated Show resolved Hide resolved
games-simulation/simutrans/simutrans-0.122.0.ebuild Outdated Show resolved Hide resolved
games-simulation/simutrans/simutrans-0.122.0.ebuild Outdated Show resolved Hide resolved
games-simulation/simutrans/simutrans-0.122.0.ebuild Outdated Show resolved Hide resolved
games-simulation/simutrans/simutrans-0.122.0.ebuild Outdated Show resolved Hide resolved
games-simulation/simutrans/simutrans-0.122.0.ebuild Outdated Show resolved Hide resolved
Also add a Desktop Entry and all the maintained paksets (scenario data) via
use-flags.

Closes: https://bugs.gentoo.org/668504
Closes: https://bugs.gentoo.org/636324
Closes: https://bugs.gentoo.org/664634
Closes: https://bugs.gentoo.org/724470
Closes: https://bugs.gentoo.org/739360
Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
It doesn't compile since 2018.

Bug: https://bugs.gentoo.org/664634
Bug: https://bugs.gentoo.org/724470
Bug: https://bugs.gentoo.org/739360

Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-10-23 16:46 UTC
Newest commit scanned: f8d29d0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4dfb4b09ae/output.html

@tastytea tastytea deleted the games-simulation/simutrans branch October 23, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
6 participants