New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
games-simulation/simutrans: Version bump 0.122.0. #15314
Conversation
Pull Request assignmentSubmitter: @tastytea games-simulation/simutrans: @gentoo/games Linked bugsBugs linked: 668504 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
9a5a221
to
17edf6a
Compare
|
||
src_install() { | ||
newbin build/default/sim ${PN} | ||
insinto /usr/share/${PN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be simplified with dodoc? It already installs into that directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to simutrans/*
? That are datafiles that go into /usr/share/simutrans
. I don't see what dodoc could do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you're right, sorry.
doins -r simutrans/* | ||
dodoc documentation/* | ||
insinto /usr/share/icons/hicolor/32x32/apps | ||
doins simutrans.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doicon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course 🤦, fixed.
pak128-german? ( mirror://sourceforge/simutrans/${SIMUPAK_128_GERMAN} -> simutrans_${SIMUPAK_128_GERMAN} ) | ||
pak192-comic? ( | ||
mirror://sourceforge/simutrans/${SIMUPAK_192_COMIC} -> simutrans_${SIMUPAK_192_COMIC} | ||
https://www.dropbox.com/s/3wwyrajrr2oqzo6/coalwagons.rar?dl=1 -> simutrans_coalwagonfix.rar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more official source for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the most official source I could find (from: https://forum.simutrans.com/index.php/topic,17735.msg168977.html#msg168977). Their git repository starts over a year later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, no problem :)
17edf6a
to
a165f4c
Compare
Pull request CI reportReport generated at: 2020-05-04 13:47 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
I suspect this fixes https://bugs.gentoo.org/664634. |
I'm sorry but it seems that games team is not really interested in this package. Would you like to take it via proxy-maint? If yes, please add yourself to metadata.xml and update this for the newest version. |
a165f4c
to
ea234f6
Compare
Updated ebuild to 122.0 and deleted 120.2.2, since it doesn't compile since 2018. Also added support for some optional dependencies. |
Pull request CI reportReport generated at: 2020-10-23 15:11 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Also add a Desktop Entry and all the maintained paksets (scenario data) via use-flags. Closes: https://bugs.gentoo.org/668504 Closes: https://bugs.gentoo.org/636324 Closes: https://bugs.gentoo.org/664634 Closes: https://bugs.gentoo.org/724470 Closes: https://bugs.gentoo.org/739360 Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
It doesn't compile since 2018. Bug: https://bugs.gentoo.org/664634 Bug: https://bugs.gentoo.org/724470 Bug: https://bugs.gentoo.org/739360 Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
ea234f6
to
f8d29d0
Compare
Pull request CI reportReport generated at: 2020-10-23 16:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Also add a Desktop Entry and all the maintained paksets (scenario data) via
use-flags.
Closes: https://bugs.gentoo.org/668504
Signed-off-by: Ronny Gutbrod gentoo@tastytea.de
I've added the other paksets because the default one uses 64x64 pixel graphics,
which most users don't want since it looks not that great on modern monitors.