New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-admin/passwordsafe: version bump to 1.09.0 #15375
Conversation
Closes: https://bugs.gentoo.org/686486 Closes: https://bugs.gentoo.org/696598 Package-Manager: Portage-2.3.89, Repoman-2.3.20 Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
Pull Request assignmentSubmitter: @madmartin app-admin/passwordsafe: @gentoo/proxy-maint (maintainer needed) Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if you'd like to become the new proxy-maintainer for this, just add yourself to metadata.xml in a separate commit.
# Copyright 2020 Gentoo Authors | ||
# Distributed under the terms of the GNU General Public License v2 | ||
|
||
EAPI=6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EAPI-7 should work here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @juippis ,
I figured out that EAPI-7 does not work without other changes. build fails with a "ld" error. I wanted to find out why in a later step, but with your comments it migth be easier for me now.
Will look at it, thanks for commenting!
Martin
|
||
WX_GTK_VER="3.0-gtk3" | ||
|
||
inherit cmake-utils desktop flag-o-matic wxwidgets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use cmake.eclass
with EAPI-7.
app-arch/zip | ||
sys-devel/gettext | ||
test? ( dev-cpp/gtest )" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that with EAPI-7 these are all most likely BDEPEND, which also allows you to remove COMMON_DEPEND
and just inherit DEPEND
in RDEPEND
.
sys-devel/gettext | ||
test? ( dev-cpp/gtest )" | ||
|
||
S=${WORKDIR}/pwsafe-${MY_PV} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S="..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juippis thanks for now, merged your hints.
closing this PR here, new PR for passwordsafe-1.11.0 coming soon
Closes: https://bugs.gentoo.org/686486
Closes: https://bugs.gentoo.org/696598
Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Martin Dummer martin.dummer@gmx.net