Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games-puzzle/world-of-goo: update and split for humblebundle and gog vendors #15388

Closed
wants to merge 2 commits into from
Closed

Conversation

CaseOf
Copy link
Contributor

@CaseOf CaseOf commented Apr 17, 2020

Hello,
I made ebuilds for both HumbleBundle and GOG providers of the game.
Chewi on #gentoo-games on freenode told me that splitting in two packages was the best solution he/she can find at that time.
This update drops sdl1 dependency and now uses sdl2.

Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
Package-Manager: Portage-2.3.89, Repoman-2.3.20
Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @CaseOf
Areas affected: ebuilds
Packages affected: games-puzzle/world-of-goo-gog, games-puzzle/world-of-goo-hb

games-puzzle/world-of-goo-gog: @gentoo/proxy-maint (new package)
games-puzzle/world-of-goo-hb: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Apr 17, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-17 17:55 UTC
Newest commit scanned: 0a2604c
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/8e5b813/output.html#www-apps/postfixadmin

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8e5b813/output.html

@juippis
Copy link
Member

juippis commented Apr 21, 2020

@chewi
@gentoo/games

Is there / should there be a bug to discuss, or is @chewi aware of your contribution here?

@chewi chewi self-assigned this Apr 21, 2020
@chewi
Copy link
Member

chewi commented Apr 21, 2020

I'm aware.

@CaseOf
Copy link
Contributor Author

CaseOf commented Apr 21, 2020

@chewi
@gentoo/games

Is there / should there be a bug to discuss, or is @chewi aware of your contribution here?

He’s aware, he saw the PR link I gave him on #gentoo-games on freenode. Feel free to ask him ;-)

@CaseOf
Copy link
Contributor Author

CaseOf commented Apr 21, 2020

Hah, you were faster than me ^_^

@chewi
Copy link
Member

chewi commented Apr 25, 2020

I hadn't realised that you can also obtain the game from 2DBOY itself if you ordered it early enough. I guess they would provide the latest version but I don't know whether it would be the same as Humble Bundle. Do we just drop the old package? Normally we could do a package move but unless it's the same download, that wouldn't make sense here.

And what about the demo? It's no longer downloadable from 2DBOY. I can only find it here, which isn't terrible so I guess we could keep it?

@CaseOf
Copy link
Contributor Author

CaseOf commented Apr 25, 2020

If we cant download it from 2DBOY, I think that, yes, we can drop legacy package. This one is the same archive as the old version (1.41) on HumbleBundle though. It has the same checksum.

About demo version, if you think that source is acceptable, we can keep it with this one.

@chewi
Copy link
Member

chewi commented Apr 28, 2020

Sorry for the wait. I did a bunch of work on top of this. Check out git if you're interested. I found that the Vorbis libraries bundled with the demo clash with system Vorbis libraries pulled in via PulseAudio, causing a crash. I then thought about dropping bundled libraries entirely as I'm not a fan but then I figured the later versions do work for me and we haven't enabled them by default.

@chewi
Copy link
Member

chewi commented Apr 28, 2020

Oh and please retry the GOG version just in case I broke it!

@CaseOf
Copy link
Contributor Author

CaseOf commented Apr 28, 2020

Ok, checking now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants