xfce-extra/xfce4-whiskermenu-plugin: version bump to 1.5.3 #1540
Conversation
|
😞 The QA check for this pull request has found the following issues: Issues persisted from underlying repository state: |
|
QA check failures are obviously not related to xfce-extra/xfce4-whiskermenu-plugin. |
|
@proxy-maint |
| if [[ -n "${LINGUAS+x}" ]] ; then | ||
| for i in *.po ; do | ||
| einfo "removing ${i%.po} linguas" | ||
| has ${i%.po} ${LINGUAS} || { rm ${i} || die ; } |
There was a problem hiding this comment.
Is it just me or this line is trying to be too smart? 🔎
There was a problem hiding this comment.
It turns out to be perfectly correct 👍
monsieurp
added
version bump
assigned
|
This may indeed appear a little too complex at first glance, but has actually been there for a long time and does exactly what it is supposed to do. In a most correct way like you say. Yet, I was irritated too when I first saw it. Just for clarification: Am I correct to ignore the bot here? AFAIK the repo was simply borked when I created my branch. There is no connection to xfce-extra/whiskermenu. CCing @perfinion from xfce-team who has already merged my last PR regarding this package. |
Very timely addendum to the wiki article: https://wiki.gentoo.org/wiki/Gentoo_Github#gentoo-repo-qa-bot_is_engaging_in_a_conversation_with_me_in_the_PR._I_don.27t_understand. |
|
Thank you very much. Hopefully the revised article will help reducing silly doubts and unnecessary questions concerning that matter. |
|
Hey, Thanks! |
Package-Manager: portage-2.2.28
Package-Manager: portage-2.2.28
|
Suggestions applied by resetting the commit and pushing two new ones to my branch. Also fixed alphabetical order in DEPEND. |
|
😞 The QA check for this pull request has found the following issues: Issues persisted from underlying repository state: |
Package-Manager: portage-2.2.28 Closes: #1540 Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
As previous maintainer hasufell is retiring, I would like to proxy-maintain xfce-extra/xfce4-whiskermenu-plugin. I have already bumped this to version 1.5.2 in commit 09e5b01. Moreover, I keep this up to date locally anyway, so why not share it.
Ebuild Changes: