app-i18n/transifex-client: bump version, support Python 3.7 #15409

robert7k · 2020-04-19T13:10:44Z

Closes: https://bugs.gentoo.org/718222
Closes: https://bugs.gentoo.org/665246

gentoo-bot · 2020-04-19T13:12:16Z

Pull Request assignment

Submitter: @robert7k
Areas affected: ebuilds, profiles
Packages affected: app-i18n/transifex-client, dev-python/python-slugify

app-i18n/transifex-client: @gentoo/proxy-maint (maintainer needed)
dev-python/python-slugify: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 665246, 718222

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2020-04-19T16:59:30Z

Pull request CI report

Report generated at: 2020-04-19 16:59 UTC
Newest commit scanned: 0ab209c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/822cd63/output.html

gentoo-repo-qa-bot · 2020-04-19T19:30:19Z

Pull request CI report

Report generated at: 2020-04-19 19:30 UTC
Newest commit scanned: 2092756
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ffea5a6/output.html

juippis

Remember to describe the new package in its commit message box in few words.

juippis · 2020-04-21T08:05:10Z

dev-python/python-slugify/python-slugify-1.2.6.ebuild

+# Copyright 1999-2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


juippis · 2020-04-21T08:05:35Z

dev-python/python-slugify/python-slugify-1.2.6.ebuild

+
+RDEPEND=">=dev-python/unidecode-0.04.16[${PYTHON_USEDEP}]"
+DEPEND="${REDEPEND}
+	dev-python/setuptools[${PYTHON_USEDEP}]


Handled with distutils-r1.eclass.

juippis · 2020-04-21T08:06:15Z

dev-python/python-slugify/python-slugify-1.2.6.ebuild

+	test? (
+		dev-python/nose[${PYTHON_USEDEP}]
+		dev-python/pytest[${PYTHON_USEDEP}]
+	)"
+
+python_test() {
+	nosetests --verbose || die
+	py.test -v -v || die
+}


This seems weird. Can you verify this is the case how python tests are run?

Maybe you can use distutils-r1.eclass to run tests too.

juippis · 2020-04-21T08:06:49Z

dev-python/python-slugify/python-slugify-1.2.6.ebuild

+IUSE="test"
+RESTRICT="!test? ( test )"
+
+RDEPEND=">=dev-python/unidecode-0.04.16[${PYTHON_USEDEP}]"


Version restriction can be lifted off, since this version doesn't exist in tree anymore.

juippis · 2020-04-21T08:07:23Z

app-i18n/transifex-client/transifex-client-0.13.9.ebuild

+# Copyright 1999-2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


juippis · 2020-04-21T08:07:53Z

app-i18n/transifex-client/transifex-client-0.13.9.ebuild

+inherit distutils-r1
+
+DESCRIPTION="A command line interface for Transifex"
+HOMEPAGE="https://pypi.org/project/transifex-client/ http://www.transifex.net/"


juippis · 2020-04-21T08:08:08Z

app-i18n/transifex-client/transifex-client-0.13.9.ebuild

+IUSE="test"
+RESTRICT="!test? ( test )"
+
+DEPEND="dev-python/setuptools[${PYTHON_USEDEP}]


Handled via distutils-r1.eclass.

juippis · 2020-04-21T08:08:28Z

app-i18n/transifex-client/transifex-client-0.13.9.ebuild

+python_test() {
+	esetup.py test
+}


You can use distutils-r1.eclass to run these.

robert7k · 2020-04-23T21:39:00Z

@juippis thank you for the review and the suggestions. I applied all of them!

Arfrever · 2020-04-23T22:26:39Z

dev-python/python-slugify/python-slugify-1.2.6.ebuild

+RESTRICT="!test? ( test )"
+
+RDEPEND="dev-python/unidecode[${PYTHON_USEDEP}]"
+DEPEND="${REDEPEND}"


REDEPEND typo :)

Besides this, if dev-python/unidecode is needed at build time, then (in case of Python modules) appropriate variable would be BDEPEND instead of DEPEND.

Thanks, fixed!

Arfrever · 2020-04-23T22:37:40Z

app-i18n/transifex-client/transifex-client-0.13.9.ebuild

+IUSE="test"
+RESTRICT="!test? ( test )"
+
+DEPEND="test? ( dev-python/mock[${PYTHON_USEDEP}] )"


BDEPEND instead of DEPEND.

gentoo-repo-qa-bot · 2020-04-24T04:55:23Z

Pull request CI report

Report generated at: 2020-04-24 04:55 UTC
Newest commit scanned: 510859c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c604ee3/output.html

juippis · 2020-04-26T07:31:45Z

dev-python/python-slugify/python-slugify-1.2.6.ebuild

+RESTRICT="!test? ( test )"
+
+BDEPEND="dev-python/unidecode[${PYTHON_USEDEP}]"
+DEPEND="${RDEPEND}"


This does nothing. Is unidecode not needed in runtime? Why would it be needed in build-time?

juippis · 2020-04-26T07:32:20Z

dev-python/python-slugify/python-slugify-1.2.6.ebuild

+BDEPEND="dev-python/unidecode[${PYTHON_USEDEP}]"
+DEPEND="${RDEPEND}"
+
+distutils_enable_tests nose


This doesn't seem to be doing anything. You should test it yourself before committing..

>>> Test phase: dev-python/python-slugify-1.2.6 * python3_6: running distutils-r1_run_phase python_test ---------------------------------------------------------------------- Ran 0 tests in 0.007s OK * python3_7: running distutils-r1_run_phase python_test ---------------------------------------------------------------------- Ran 0 tests in 0.009s

I did test this, but I somehow oversaw that this specific version comes without tests.

So I removed the tests from the ebuild, sorry for the confusion.

I mean, the Github release does include tests.
https://github.com/un33k/python-slugify/tree/beca50eaff20ca20652df782354a8f184c1eaf4c

Please us that instead. Looks like ${EPYTHON} test.py || die "tests failed with ${EPYTHON}" inside python_test() is enough to get them to work.

Yes, but the release tar.gz doesn't contain the tests anymore.

See the file linked here: https://pypi.org/project/python-slugify/1.2.6/#files

Use https://github.com/un33k/python-slugify/archive/1.2.6.tar.gz

Done. Now the tests also work with distutils_enable_tests :)

gentoo-repo-qa-bot · 2020-04-26T13:30:08Z

Pull request CI report

Report generated at: 2020-04-26 13:30 UTC
Newest commit scanned: 496017f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/69c491d/output.html

A Python Slugify application that handles Unicode. Required for app-i18n/transifex-client. Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

Closes: https://bugs.gentoo.org/718222 Closes: https://bugs.gentoo.org/665246 Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

gentoo-repo-qa-bot · 2020-04-28T11:07:05Z

Pull request CI report

Report generated at: 2020-04-28 11:07 UTC
Newest commit scanned: 6a14ee3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7150296/output.html

juippis · 2020-04-29T10:23:51Z

b6a3769

robert7k force-pushed the transifex branch 5 times, most recently from 1301e72 to 2092756 Compare April 19, 2020 16:41

robert7k changed the title ~~app-i18n/transifex-client: bump version to prevent removal from tree~~ app-i18n/transifex-client: bump version, support Python 3.7 Apr 19, 2020

juippis reviewed Apr 21, 2020

View reviewed changes

robert7k force-pushed the transifex branch from 2092756 to 7e63d6c Compare April 23, 2020 21:38

robert7k requested a review from juippis April 23, 2020 21:38

robert7k force-pushed the transifex branch from 7e63d6c to 3d8237c Compare April 23, 2020 21:40

Arfrever reviewed Apr 23, 2020

View reviewed changes

robert7k force-pushed the transifex branch from 3d8237c to cae6f91 Compare April 23, 2020 22:31

Arfrever reviewed Apr 23, 2020

View reviewed changes

robert7k force-pushed the transifex branch from cae6f91 to 510859c Compare April 23, 2020 22:42

juippis reviewed Apr 26, 2020

View reviewed changes

robert7k force-pushed the transifex branch from 510859c to 496017f Compare April 26, 2020 10:41

robert7k requested a review from juippis April 26, 2020 10:42

robert7k force-pushed the transifex branch from 496017f to 9ef843d Compare April 28, 2020 08:06

robert7k added 2 commits April 28, 2020 10:14

dev-python/python-slugify: add ebuild

219a58a

A Python Slugify application that handles Unicode. Required for app-i18n/transifex-client. Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

app-i18n/transifex-client: take maintainership

3bec902

Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

robert7k added 2 commits April 28, 2020 10:14

app-i18n/transifex-client: add version 0.13.9

426e4af

Closes: https://bugs.gentoo.org/718222 Closes: https://bugs.gentoo.org/665246 Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

app-i18n/transifex-client: remove old version

6a14ee3

Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>

robert7k force-pushed the transifex branch from 9ef843d to 6a14ee3 Compare April 28, 2020 08:14

juippis approved these changes Apr 29, 2020

View reviewed changes

juippis closed this Apr 29, 2020

robert7k deleted the transifex branch April 30, 2020 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app-i18n/transifex-client: bump version, support Python 3.7 #15409

app-i18n/transifex-client: bump version, support Python 3.7 #15409

robert7k commented Apr 19, 2020

gentoo-bot commented Apr 19, 2020

gentoo-repo-qa-bot commented Apr 19, 2020

gentoo-repo-qa-bot commented Apr 19, 2020

juippis left a comment

juippis Apr 21, 2020

juippis Apr 21, 2020

juippis Apr 21, 2020

juippis Apr 21, 2020

juippis Apr 21, 2020

juippis Apr 21, 2020

juippis Apr 21, 2020

juippis Apr 21, 2020

robert7k commented Apr 23, 2020

Arfrever Apr 23, 2020

robert7k Apr 23, 2020

Arfrever Apr 23, 2020

robert7k Apr 23, 2020

gentoo-repo-qa-bot commented Apr 24, 2020

juippis Apr 26, 2020

robert7k Apr 26, 2020

juippis Apr 26, 2020

robert7k Apr 26, 2020

juippis Apr 28, 2020

robert7k Apr 28, 2020

robert7k Apr 28, 2020

juippis Apr 28, 2020

robert7k Apr 28, 2020

gentoo-repo-qa-bot commented Apr 26, 2020

gentoo-repo-qa-bot commented Apr 28, 2020

juippis commented Apr 29, 2020

app-i18n/transifex-client: bump version, support Python 3.7 #15409

app-i18n/transifex-client: bump version, support Python 3.7 #15409

Conversation

robert7k commented Apr 19, 2020

gentoo-bot commented Apr 19, 2020

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Apr 19, 2020

Pull request CI report

gentoo-repo-qa-bot commented Apr 19, 2020

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robert7k commented Apr 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Apr 24, 2020

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Apr 26, 2020

Pull request CI report

gentoo-repo-qa-bot commented Apr 28, 2020

Pull request CI report

juippis commented Apr 29, 2020