Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/oprofile: Add fix for binutils 2.34 re bug #707850 #15469

Closed

Conversation

kentfredric
Copy link
Contributor

This adds the patch attached on bug #707850, and adds the glue
required to make it work.

I've used java-pkg-opt-2_src_prepare as the "do this after patching"
because analysis of the environment file for this ebuild indicated
that's what src_prepare was already doing.

This may not be the best thing, but it works.

Repoman also warns about using 'user' instead of GLEP81, and I
have not fixed this, but somebody should.

Bug: https://bugs.gentoo.org/707850
Package-Manager: Portage-2.3.97, Repoman-2.3.22
Signed-off-by: Kent Fredric kentnl@gentoo.org

Diff between 1.3.0.ebuild and 1.3.0-r1.ebuild:

--- oprofile-1.3.0.ebuild	2020-04-23 01:54:04.170617268 +1200
+++ oprofile-1.3.0-r1.ebuild	2020-04-23 02:02:55.610295125 +1200
@@ -10,7 +10,7 @@
 
 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="~alpha amd64 arm ~hppa ~mips ppc ppc64 ~sparc x86"
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~mips ~ppc ~ppc64 ~sparc ~x86"
 IUSE="java pch"
 
 RDEPEND=">=dev-libs/popt-1.7-r1
@@ -38,6 +38,10 @@
 
 	use java && java-pkg_init
 }
+src_prepare() {
+	eapply "${FILESDIR}/${PN}-1.3.0-binutils-2.24.patch"
+	java-pkg-opt-2_src_prepare
+}
 
 src_configure() {
 	econf \

This adds the patch attached on bug #707850, and adds the glue
required to make it work.

I've used java-pkg-opt-2_src_prepare as the "do this after patching"
because analysis of the environment file for this ebuild indicated
that's what src_prepare was already doing.

This may not be the best thing, but it works.

Repoman also warns about using 'user' instead of GLEP81, and I
have not fixed this, but somebody should.

Bug: https://bugs.gentoo.org/707850
Package-Manager: Portage-2.3.97, Repoman-2.3.22
Signed-off-by: Kent Fredric <kentnl@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @kentfredric
Areas affected: ebuilds
Packages affected: dev-util/oprofile

dev-util/oprofile: @bircoph

Linked bugs

Bugs linked: 707850


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 22, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-22 16:29 UTC
Newest commit scanned: 6e5f2c8
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/c9cbc0f/output.html#dev-util/oprofile

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c9cbc0f/output.html

@kentfredric
Copy link
Contributor Author

Report failure is just the "user" problem I mentioned earlier ( it makes the 'new' classification because of the addition of the -r1 ebuild increases the number of output lines ). Feel free to ignore.

NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this pull request Jun 29, 2020
Use upstream patch 377610414fb6cd7ac30e4485d9d6482fcf29aca6 to fix
build with new binutils api (2.34) while keeping compatibility
support with older versions.

Closes: https://bugs.gentoo.org/707850
Closes: gentoo#15469
Package-Manager: Portage-2.3.82, Repoman-2.3.20
Signed-off-by: Andrew Savchenko <bircoph@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
3 participants