net-fs/davfs2: version bump to 1.5.2 #517732 #155
Conversation
| RESTRICT="test" | ||
|
|
||
| DEPEND="dev-libs/libxml2 | ||
| net-libs/neon |
There was a problem hiding this comment.
I smell extraneous tabs here
|
@gentoo/net-fs |
| DEPEND="dev-libs/libxml2 | ||
| net-libs/neon | ||
| sys-libs/zlib" | ||
| RDEPEND="${DEPEND}" |
There was a problem hiding this comment.
Used a single tab indent instead of two here. Is this the expected change?
|
I removed eutils. Previous versions used epatch but not this version. |
|
sorry, didn't mean to delete the remote branch |
|
Modified the commit msg based on the feedback from idella4 |
| } | ||
|
|
||
| src_configure() { | ||
| econf dav_user=nobody --enable-largefile --docdir=/usr/share/doc/${P} |
There was a problem hiding this comment.
If i may nitpick a bit, it's usually a good idea to use \ here and pass one parameter per line.
Bump davfs2 to version 1.5.2. The ebuild has submitted via the bug 517732 and the original author is Chema Alonso <nimiux@gentoo.org>. Gentoo-Bug: https://bugs.gentoo.org/517732 Github-PR: #155 Package-Manager: portage-2.2.20.1
|
They overrode src_compile() because it was inheriting linux-mod. linux-mod has a default action for src_compile() which doesn't compile the source because this is not a kernel module. It seems the change has been introduced 9 years ago: It also doesn't need to inherit autotools because eautoreconf is not needed. fixed that too. |
|
@gentoo/net-fs I can merge this PR if you guys want. |
|
At a first glance, the ebuild looks great and that's a nice work you did there. I'm going to test it myself and then merge it. |
Bump davfs2 to version 1.5.2. The ebuild has adopted from bug 517732
and the original author is Chema Alonso nimiux@gentoo.org. The ebuild
has been modified to reflect the year 2015 on the copyright line.
Gentoo-Bug: https://bugs.gentoo.org/517732
Package-Manager: portage-2.2.20.1