Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-shells/fzf: bump to 0.21.1 #15511

Closed
wants to merge 1 commit into from
Closed

app-shells/fzf: bump to 0.21.1 #15511

wants to merge 1 commit into from

Conversation

heroin-moose
Copy link
Contributor

@heroin-moose heroin-moose commented Apr 25, 2020 •
edited

Hi, new bugfix release is out so here we go. I've fixed some things (like missing manual page or muted einfo output).

I also think it's kinda pointless to print this on every package update:

* app-shells/bash-completion for bash-completion support
* app-shells/fish for fish-completion support
* app-editors/vim for fzf plugin for vim

A bet no one will think "wow, there is an fzf plugin for Vim, let's install Vim!" Usually people search plugins to their software, not software for their plugins. So I've nuked it.

I also moved fzf.${shell} to key-bindings.${shell} in order to make things easier to understand if a user missed our message. I believe it won't break many setups since previous ebuild was out a day or two.

@rafspiny, ok?

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @heroin-moose
Areas affected: ebuilds
Packages affected: app-shells/fzf

app-shells/fzf: @rafspiny, @gentoo/proxy-maint

Linked bugs

Bugs linked: 719346

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 25, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-25 08:21 UTC
Newest commit scanned: 23a5598
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/eddaf5f/output.html

@rafspiny
Copy link
Contributor

@heroin-moose

A bet no one will think "wow, there is an fzf plugin for Vim, let's install Vim!" Usually people search plugins to their software, not software for their plugins. So I've nuked it.

I guess the vim message could go. I would still notify the user though. Maybe replace it with something like this?
Vim support has been added as a plugin

I also moved fzf.${shell} to key-bindings.${shell} in order to make things easier to understand if a user missed our message. I believe it won't break many setups since previous ebuild was out a day or two.

No preference here : )
Even keeping the files name and put them in a key-binding subfolder will do. Whichever you prefer.

@heroin-moose
Copy link
Contributor Author

Vim support has been added as a plugin

Yeah, sounds good, I'll update PR.

@heroin-moose
Copy link
Contributor Author

Pushed.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-26 18:46 UTC
Newest commit scanned: 1674a49
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/934004b/output.html

juippis
juippis reviewed Apr 28, 2020
View reviewed changes
app-shells/fzf/fzf-0.21.1.ebuild Outdated Show resolved Hide resolved
app-shells/fzf/fzf-0.21.1.ebuild Outdated Show resolved Hide resolved
app-shells/fzf/fzf-0.21.1.ebuild Outdated Show resolved Hide resolved
@heroin-moose
app-shells/fzf: bump to 0.21.1
827b07b 
Highlights:

* Install fzf(1) manual page

* Replace einfo with elog; einfo is muted when emerge is running
  in parallel mode

* Make shell commands easier to spot in elog messages

* Clarify that bash keybindings are in fact keybindings and are in fact
  bash-specific

* Remove kinda pointless optfeature noise

Closes: https://bugs.gentoo.org/719346
Signed-off-by: Olaf Torvaldsson <consus@ftml.net>
@heroin-moose
Copy link
Contributor Author

Updated.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-29 11:31 UTC
Newest commit scanned: 827b07b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/50f2c2d/output.html

@heroin-moose heroin-moose deleted the bump-fzf-0.21.1 branch April 29, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@heroin-moose @gentoo-bot @gentoo-repo-qa-bot @rafspiny @juippis