Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-p2p/amule: Add missing dependencies #15567

Closed
wants to merge 3 commits into from
Closed

net-p2p/amule: Add missing dependencies #15567

wants to merge 3 commits into from

Conversation

puleglot
Copy link
Contributor

No description provided.

@puleglot
net-p2p/amule: Add missing readline dep to live ebuild
5cc1430 
Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
@puleglot
net-p2p/amule: Sync 2.3.2 with live ebuild
67f9547 
* Added missing dependencies on sys-devel/gettext, virtual/libintl,
  sys-libs/readline.
* Added MimeType handler to a .desktop file (this also justifies added
  dependency on dev-util/desktop-file-utils and xdg-utils eclass usage).

Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
@puleglot
net-p2p/amule: Remove old
8c3a0e3 
Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @puleglot
Areas affected: ebuilds
Packages affected: net-p2p/amule

net-p2p/amule: @puleglot, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Apr 29, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-04-29 18:52 UTC
Newest commit scanned: 8c3a0e3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1203049/output.html

juippis
juippis reviewed Apr 30, 2020
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe desktop-file-utils is also a BDEPEND, but verify and fix for next round.

@puleglot
Copy link
Contributor Author

BDEPEND does not guarantee that dependency is installed at pkg_* phases. E. g. if a package is being installed from binpkg.

@juippis
Copy link
Member

juippis commented Apr 30, 2020

Oh right, yep.

@puleglot puleglot deleted the amule-readline-dep branch April 30, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@puleglot @gentoo-bot @gentoo-repo-qa-bot @juippis